Segmentation Panel Will not add a new segmentation if Layout is changed [Bug]

[BrandonDatUHN]

Describe the Bug

3.8.0-beta.85

When using Segmentation Mode, if the user changes their layout before creating a new Segmentation the Add Segmentation button will not work.

When using the default layout it works fine.

Steps to Reproduce

1. Go to a study in Segmentation mode - https://viewer-dev.ohif.org/segmentation?StudyInstanceUIDs=1.2.840.113619.2.290.3.3767434740.226.1600859119.501
2. Change the layout to 2x2
3. Click +Add Segmentation
4. Nothing will happen

The current behavior

If the user changes from the default Layout while in segmentation mode before clicking +Add Segmentation button will no longer add new Segmentations.

The expected behavior

Add Segment should work regardless of if Layout is changed before or after +Add Segmentation is clicked.

OS

Windows 11

Node version

Using OHIF Demo

Browser

123.0.6312.59 (Official Build) (64-bit)

[jenny-hm-lee]

@sedghi , this bug is still reproducible on 3.8.0-beta.87

[BrandonDatUHN]

Looks good on 3.8.90

[BrandonDatUHN]

@sedghi It looks like this bug is back in version 3.9.2 (what we have on our dev) and also on 3.9.4 (current https://viewer-dev.ohif.org/)

[BrandonDatUHN]

I should add I don't see the error using https://viewer-dev.ohif.org/segmentation?StudyInstanceUIDs=1.2.840.113619.2.290.3.3767434740.226.1600859119.501

but I do see it here now. so might have a different root cause but the behaviour (no segment appearing) is the same/ https://viewer-dev.ohif.org/segmentation?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7009.2403.871108593056125491804754960339

https://www.loom.com/share/19bb0319711e4623accfd6f272a3e20d?sid=11a40b7b-b1c5-4e74-bf1a-97de5c53d5fc

[BrandonDatUHN]

using https://viewer-dev.ohif.org/segmentation?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7009.2403.871108593056125491804754960339

1. Change layout to 1x2
2. Will default to scout and PET
3. Drag the CT onto the scout window
4. Try and create a new segmentation on the CT nothing happens
5. Try and create on the PET segmentation will happen

using https://viewer-dev.ohif.org/segmentation?StudyInstanceUIDs=1.2.840.113619.2.290.3.3767434740.226.1600859119.501

1. change layout to 1x2
2. will default to 2 CTs on top
3. change left panel to a PET via drag and drop
4. Can't create segmentation on PET but can create on CT

So it seems to be more that you can't create it on a newly dragged in image set

[sedghi]

We released OHIF 3.9 which address this issue