Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

fix: use defaultTool if failed to use same tool in new hanging protoc…

Open dxlin opened this issue 1 year ago • 4 comments

fix: use defaultTool if failed to use same tool in new hanging protocol stage

Context

Briefly reviewed to resolve crosshair misalignment issue from: https://github.com/OHIF/Viewers/issues/3911

Was not able to locate root cause of misalignment, may have to do with button/tool state but didn't try to investigate further due to development in toolbar: https://github.com/OHIF/Viewers/issues/3927

It does appear turning off crosshair and re-enabling after 2nd entry into MPR mode resolves the issue.

Changes & Results

Simplest workaround was to default to a default tool when switching to primaryToolBeforeHPChange doesn't work.

Crosshair now off when switching back into MPR and initial misalignment will not be visible to end user.

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments, etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

dxlin avatar Feb 22 '24 18:02 dxlin

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit d502a68dee7fe8a1154c29782908af606a504581
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/65d791f9435dcf0008b1ba53
Deploy Preview https://deploy-preview-3954--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 22 '24 18:02 netlify[bot]

Deploy Preview for ohif-dev ready!

Name Link
Latest commit d502a68dee7fe8a1154c29782908af606a504581
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/65d791f9fd1574000833dbf8
Deploy Preview https://deploy-preview-3954--ohif-dev.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 22 '24 18:02 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.44%. Comparing base (8a335bd) to head (d502a68). Report is 312 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3954      +/-   ##
==========================================
- Coverage   46.23%   44.44%   -1.80%     
==========================================
  Files          78       80       +2     
  Lines        1276     1332      +56     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      587      +39     
- Partials      138      153      +15     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a442e3...d502a68. Read the comment docs.

codecov[bot] avatar Feb 22 '24 18:02 codecov[bot]

I'm revamping the toolbar very soon, all of these problems will go away, I think we wait for my changes and later decide on this

sedghi avatar Mar 05 '24 16:03 sedghi

Hi @sedghi what is the update on this PR?
Is the toolbar changes finished, can we help testing?

jenny-hm-lee avatar Mar 25 '24 15:03 jenny-hm-lee

we have revamped the toolbar and this is not applicable anymore

sedghi avatar Apr 10 '24 14:04 sedghi

@sedghi , this PR aims to fix issue #3911 , which still exist on OHIF dev viewer. @dxlin will update the PR, as the toolbar has changed a lot since.
Please reopen this PR.

jenny-hm-lee avatar Apr 10 '24 19:04 jenny-hm-lee