feat(layout): new layout selector

[IbrahimCSAE]

Context

Addresses issue/ feature request https://github.com/OHIF/Viewers/issues/3643

Changes & Results

• Created new LayoutPreset Component
• Updated design of Layout Selector

Testing

Visit https://deploy-preview-3923--ohif-dev.netlify.app/viewer?StudyInstanceUIDs=2.16.840.1.114362.1.11972228.22789312658.616067305.306.2

And test out the different presets.

Checklist

PR

• [x] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

• [x] My code has been well-documented (function documentation, inline comments, etc.)

Public Documentation Updates

• [x] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

• [x] OS: Linux Ubuntu
• [x] Browser: Chrome

Issues

• Switching from a 3D hanging protocol to none 3D one causes the entire browser window to go black
• Sometimes switching to a 3D hanging protocol will not render anything.
• Toolbar is not visible if the selected viewport is the 3D one, select a non 3D viewport to make the toolbar re-appear, this is problematic if you are in the 3D only hanging protocol.

[netlify[bot]]

✅ Deploy Preview for ohif-dev canceled.

Name	Link
🔨 Latest commit	b9cad5c3041589ea23764bcd12e0432df5287364
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/6605799f6e0148000813e1cc

[netlify[bot]]

✅ Deploy Preview for ohif-platform-docs canceled.

Name	Link
🔨 Latest commit	b9cad5c3041589ea23764bcd12e0432df5287364
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/6605799f3b54ec0008df9fc2

[IbrahimCSAE]

Just need to add 1 missing icon from Dan, and then there's these two issues I noticed that are mentioned in the pull, no idea what the cause is yet.

I can notice some of the issues happening because of something in https://github.com/OHIF/Viewers/blob/306bcea788ca6048ce49a2c513909a386e8fa258/extensions/cornerstone/src/init.tsx#L186

the presentations not being defined, maybe the calls are happening in the wrong order.

@sedghi

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.41%. Comparing base (8a335bd) to head (b9cad5c). Report is 266 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3923      +/-   ##
==========================================
- Coverage   46.23%   44.41%   -1.83%     
==========================================
  Files          78       80       +2     
  Lines        1276     1333      +57     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      588      +40     
- Partials      138      153      +15     

see 9 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f610b0...b9cad5c. Read the comment docs.

[cypress[bot]]

Passing run #3774 ↗︎

0

43

0

0

0

Details:

fix build
Project: Viewers	Commit: b9cad5c304
Status: Passed	Duration: 05:52 💡
Started: Mar 28, 2024 2:19 PM	Ended: Mar 28, 2024 2:25 PM

Review all test suite changes for PR #3923 ↗︎

[IbrahimCSAE]

@sedghi I addressed the comments, I can look more into the bugs that are happening on Monday.

[IbrahimCSAE]

before you merge I think you need to add your toolbar changes to the modes, I only see trackballrotate in basic viewer, and the crosshairs don't disable as expected in segmentation mode but works good in basic viewer.

[rmasad]

Testing this: https://deploy-preview-3923--ohif-dev.netlify.app/viewer?StudyInstanceUIDs=2.16.840.1.114362.1.11972228.22789312658.616067305.306.2

Great work!

Just one detail, when you click on some 3D layout and then put a normal layout, it goes black

[sedghi]

@rmasad Yeah i know that and working on it right now

[rmasad]

thanks @sedghi!