Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

dicom-microscopy bulkDataURI fixed to localhost [Bug]

Open helghast79 opened this issue 1 year ago • 2 comments

Describe the Bug

I'm running ohif version 3.8.0-beta.53 using the default config with the following changes:

dataSources:[{
    namespace: "@ohif/extension-default.dataSourcesModule.dicomweb",
    sourceName: "dicomweb",
    configuration: {
        friendlyName: "Cliniti Pacs Server",
        name: "orthanc cliniti",
        wadoUriRoot: "/orthanc/dicom-web",
        qidoRoot: "/orthanc/dicom-web",
        wadoRoot: "/orthanc/dicom-web",
        qidoSupportsIncludeField: !1,
        supportsReject: !1,
        imageRendering: "wadors",
        thumbnailRendering: "wadors",
        enableStudyLazyLoad: !0,
        supportsFuzzyMatching: !1,
        supportsWildcard: !0,
        staticWado: !0,
        singlepart: "bulkdata,video,pdf",
        bulkDataURI: {
            enabled: !0,
            relativeResolution: "studies"
        },
        omitQuotationForMultipartRequest: !0
    }
},
{ 
    namespace:"@ohif/extension-default.dataSourcesModule.dicomjson",
    sourceName:"dicomjson",
    configuration:{
        friendlyName:"dicom json",
        name:"json"
    }
},
{
    namespace:"@ohif/extension-default.dataSourcesModule.dicomlocal",
    sourceName:"dicomlocal",
    configuration:{
        friendlyName:"dicom local",
        name:"local"
    }
}]

The app displays the studies in normal viewer mode but in microscopy it fails to get the bulkdata request because the url is fixed to localhost.

In your demo of the plugin, I noticed that the url is:

https://d33do7qe4w26qo.cloudfront.net/dicomweb/studies/2.25.275741864483510678566144889372061815320/bulkdata/68d/bc/75b4f2aa70f3e9796fbba96c3b7ea3793dfc56494b2bff9f2d47f4319b6

but in mine is:

https://localhost/dicom-web/studies/1.23455678890.4534534.121212.564566767677898898/series/1.03455678890.4534534.121212.564566767677800000/instances/1.2.276.0.7230010.3.1.4.671769906.3909415.1707294198.359069/bulk/00480105/1/00282000

So how can I configure this differently?

Steps to Reproduce

clone adjust config build nginx setup with reverse proxy to the correct address

The current behavior

fails to load bulkdata

The expected behavior

to form the the bulkdataUrl in the same way as with the other dicom-web resources

OS

ubuntu

Node version

20

Browser

chrome

helghast79 avatar Feb 07 '24 15:02 helghast79

There is a PR to fix this

sedghi avatar Feb 07 '24 19:02 sedghi

this one? current version has deviated significantly since then. the BulkDataURI seems to be returned from naturalizeDataset function of DCMJ where, in my case, it is already an absolute path (https://localhost/dicom-web/...) so it remains unchanged in fixBulkDataURI function.

helghast79 avatar Feb 07 '24 22:02 helghast79