Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

[Feature Request] Advanced ROI Tools

Open sedghi opened this issue 1 year ago • 8 comments

What feature or change would you like to see made?

We should bring the latest development in Cornerstone3D regarding the SplineROI tools.

We currently lack the ROI tools fully which is not good.

Why should we prioritize this feature?

Also

  • [ ] https://github.com/OHIF/Viewers/issues/3721

Design with full toolbar and menu specs added on Feb 20, @dan-rukas

Final OHIF Tool assets: ohif-toolbar-icons-complete-Feb22.zip

Image

Image

sedghi avatar Nov 28 '23 21:11 sedghi

@dan-rukas @sedghi lets discuss at design review meeting to determine how this can fit into current design

james-hanks avatar Nov 29 '23 18:11 james-hanks

Two artboards (with specs and examples):

Image

Image

dan-rukas avatar Feb 20 '24 19:02 dan-rukas

Attached are all of the original OHIF toolbar icon designs with the new 28x28 artboard size. All icons should be consistent and make the above implementation easier and more consistent in the Viewer when displayed (no longer displaying smaller than originally designed).

(Edit: Link Removed - Updated icon set posted 2 comments below)

dan-rukas avatar Feb 21 '24 14:02 dan-rukas

I also found a display bug that causes "active tools" to change position when hovering. This causes tools to jiggle in place. Screen recording below.

This may be related to the padding and icon size of assets being fixed already in this issue.

https://github.com/OHIF/Viewers/assets/2745168/8de66e79-68a1-4bd6-9a94-c7777d841a66

dan-rukas avatar Feb 21 '24 14:02 dan-rukas

Attached is the most updated complete set of OHIF Toolbar icons at 28x28 size.

Note - this includes re-created icons for these tools, so they likely have a different name than what is currently in the viewer:

  • tool-crosshair.svg
  • tool-stack-image-sync.svg
  • tool-dicom-tag-browser.svg

ohif-toolbar-icons-complete-Feb22.zip

dan-rukas avatar Feb 22 '24 18:02 dan-rukas

Quick note: For all of the dropdown lists layout, spacing, and margin notes are detailed in this issue for the W/L menu component: https://github.com/OHIF/Viewers/issues/3493#issue-1771651740

dan-rukas avatar Feb 23 '24 14:02 dan-rukas

@dan-rukas can you please include the new magnify tool too? thanks

sedghi avatar Feb 23 '24 15:02 sedghi

Also this https://github.com/OHIF/Viewers/issues/3721

sedghi avatar Feb 28 '24 18:02 sedghi

Most of the icon resizings are done already

sedghi avatar Mar 28 '24 13:03 sedghi

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/ If you still encounter this issue in 3.8, please re-open this.

sedghi avatar May 01 '24 17:05 sedghi