[DRAFT]: Add 4D dynamic volume preclinical mode

[lscoder]

[netlify[bot]]

✅ Deploy Preview for ohif-platform-docs canceled.

Name	Link
🔨 Latest commit	82b3c132bbfc5b1b4394f913db20114da7e8835d
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/66160ac03687e50008ca67c6

[netlify[bot]]

✅ Deploy Preview for ohif-dev canceled.

Name	Link
🔨 Latest commit	82b3c132bbfc5b1b4394f913db20114da7e8835d
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/66160ac0febb39000884959f

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.37%. Comparing base (dc0b183) to head (82b3c13).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3664   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files          80       80           
  Lines        1334     1334           
  Branches      327      327           
=======================================
  Hits          592      592           
  Misses        589      589           
  Partials      153      153           

Files	Coverage Δ
platform/app/src/appInit.js	0.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc0b183...82b3c13. Read the comment docs.

[lscoder]

af6f558cd2c99a357d4cec2c3b293859f8db338c fix(DicomMetadataStore): improved performance

Made some changes to DicomMetadataStore because some methods were taking a lot of time to run due to a O(n) search (instances). These are the times for a study with 9400 instances:

• getTimePointsRequests: +12s > 83ms
• get4DVolumeInfo: +9s > 79ms
• addInstances : +3s > 245ms

I also pushed a few other minor fixes:

• HP > initialImageOptions > preset is now set to middle instead of working with slice index
• PanelGenerateImage is now checking if cine is valid before calling any method and throwing an exception because when the viewer loads there is no active viewport selected (returns default)
• ActiveViewportWindowLevel was updated because an error message was being logged in the console by ViewportWindowLevel because activeViewportId is set to null when ActiveViewportWindowLevel is instantiated

[fedorov]

Add 4D dynamic volume preclinical mode

What should one do if the 4D dataset is not a preclinical one?

[sedghi]

@fedorov I don't think it is related to preclinical, we are targeting some known dicom tags to quantify the time dimension. So if the data uses them there would be no issue

[fedorov]

I don't think it is related to preclinical

Thank you for the clarification. I was confused by the title of this PR.

[sedghi]

The remaining work for this PR to get merged

• [ ] Rework the new UI elements for the 4D panel (see below)
• [ ] Making the 4D panel dynamically activated based on the context on the basic viewer mode
• [ ] Rework the segmentation panel for the dynamic pt/ct mode based on the new design (see below)