Viewers [Feature Request] v3: impossible to know which of the segmentation series is being displayed

What feature or change would you like to see made?

Indicate to the user which segmentation series is being displayed

Why should we prioritize this feature?

There may be more than one segmentation series in the study. In v2, it was possible to access individual segmentations in the UI, but in v3 I do not see any UI elements to indicate which series is being shown. For a demonstration and to see the differences between v2 and v3, please see #3420 that has links and screenshots.

May 25 '23 16:05 fedorov

I think it's because there's a bug. After loading segmentations with "YES", the SEG group names aren't auto-populating. The user must manually rename them again. Filed bug report #3426

May 29 '23 15:05 03shek

@fedorov, would you consider #3426 covering this request?

Jun 21 '23 12:06 jbocce

I have hard times understanding what exactly is requested in that issue.

Jun 21 '23 17:06 fedorov

@fedorov If there's a name for a SEG or RTSTRUCT file on the left, when that file is loaded, that name should be present in the collapsible SEG list title bar above its ROIs

Jun 21 '23 18:06 03shek

Thank you for the clarification! I am not sure what "name" means, but showing SeriesDescription for the loaded SEG/RTSTRUCT would do it for me.

Jun 26 '23 14:06 fedorov

This issue and https://github.com/OHIF/Viewers/issues/3426 will be addressed by the same change. For now I will keep both open so that each reporter can verify/comment on the ultimate fix.

Jun 26 '23 16:06 jbocce

Hi @fedorov, here is a PR that was just merged, could you please have a look to determine if it addresses this feature request? Thanks.

Jul 04 '23 19:07 jbocce

Can you please confirm if it is live in https://viewer.ohif.org/?

Jul 05 '23 13:07 fedorov

Can you please confirm if it is live in https://viewer.ohif.org/?

@fedorov,

It is live in https://viewer-dev.ohif.org/. The link you sent is for released versions of OHIF. Note the -dev.

Jul 05 '23 13:07 jbocce

I'd say the current implementation is not sufficient. Neither SeriesDescription, nor SeriesNumber are required to have unique values. Would it be possible to highlight the corresponding series in the list on the left?

Jul 05 '23 14:07 fedorov

Also, what is the semantics of that name shown on the right? If it is supposed to match SeriesDescription, why is it editable? Are you planning to overwrite SeriesDescription at the source if the user renames it? This would not be a good idea.

Jul 05 '23 14:07 fedorov

I agree. ~Those editable features must've been carried over from the measurements list.~ In general, RTstructs and SEGs are not overwritten anyway, but created anew. In the context of OHIF, these files are read-only. On the left, it currently doesn't show any series numbers for RTstructs or SEGs. If there could be a highlighted bounding box to also indicate a SEG has already been loaded in the session, that would also be helpful.

Jul 05 '23 15:07 03shek

In the context of OHIF, these files are read-only.

I didn't know what is the expected behavior here. But if those are supposed to be read-only, then it is also related to https://github.com/OHIF/Viewers/issues/3357.

Jul 05 '23 15:07 fedorov

Sorry I should've clarified "In the context of OHIF [Basic Viewer], these files are read-only."

Jul 05 '23 15:07 03shek

And yes, in essence, your recommendation above is identical to #3357. Since there's no way to create SEGs or overwrite them in Basic Viewer at present, relabeling them would achieve nothing outside of the current study session.

Jul 05 '23 15:07 03shek

@fedorov, @03shek

Thanks for all the feedback. It would be great if we could perhaps summarize what the requirements are here. I will give it a first shot and maybe you can respond accordingly with any updates or corrections. Thanks.

the segment label on the right side should NOT be editable
the segment label on the right side should be auto-populated with the related SEG series description
some indication on the left-side should be provided to indicate that a particular SEG has been hydrated.

Jul 05 '23 15:07 jbocce

Thanks @jbocce . Both segment labels and series description on the right side should NOT be editable.

Jul 05 '23 18:07 03shek

Thanks @03shek. Just to further clarify, are you suggesting that ALL series descriptions and labels circled in red below should NOT be editable?

Jul 05 '23 18:07 jbocce

are you suggesting that ALL series descriptions and labels circled in red below should NOT be editable?

I agree with @03shek - I have yet to hear the explanation why they would be editable, and where those edited items will be saved.

in essence, your recommendation above is identical to https://github.com/OHIF/Viewers/issues/3357.

@03shek I think it is different. The issue here is that certain items should not be editable at all (in this case, modification of SeriesDescription for the existing series or modification of anything inside that series, unless the user is clearly alerted what happens after this edit is done and where the modified content is saved), under any circumstances. The issue in #3357 is about disabling the ability to edit metadata or the image annotations, for those items that makes sense to have as editable ins specific situations. Do you agree?

Jul 05 '23 18:07 fedorov

Just to be clear, at this point I want to gather what is required. I am not trying to explain whether they should or should not be editable. Once the requirements are gathered then we can go from there. Does that make sense? 😊

Jul 05 '23 18:07 jbocce

I am trying to understand the logic of the current behavior, since that might change my perspective on the requirements. But fair enough - I hope I provided sufficient justification for the expected behavior in the above - let me know if you need any more clarifications!

Jul 05 '23 19:07 fedorov

@fedorov Right. #3357 is not a redundant issue. But one of the 3 bullets:

Is it possible to disable all editing features (both editing of the images, but also editing of things like segment labels)?

The last bit is relevant to the current issue #3421 as an updated requirement; to disable editing segment labels (in Basic Viewer only). There's no point in modifying SEGs in Basic Viewer if they were never able to be created or saved from there in the first place.

I think SEGs can only be created in TMTV mode. It makes sense, there, to leave those segment labels and Series Description editable. And by editable, I mean read existing, allow modification, and create new files when saved: not overwrite.

Jul 05 '23 19:07 03shek

Here are some recommendations for a color state change in the Studies panel: