Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

feat: added voiLUTFunction to MetadataProvider

Open Ouwen opened this issue 3 years ago • 6 comments

Adds voiLUTFunction to the MetadataProvider VOI_LUT_MODULE

Ouwen avatar Sep 26 '22 11:09 Ouwen

Deploy Preview for ohif-platform-viewer canceled.

Name Link
Latest commit 405fa94ce851e769bce3e04a3be65f0e7768518a
Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/63d9ef40e1ab7d0007973db8

netlify[bot] avatar Sep 26 '22 11:09 netlify[bot]

Deploy Preview for ohif-platform-docs canceled.

Name Link
Latest commit 405fa94ce851e769bce3e04a3be65f0e7768518a
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/63d9ef41db9f0c000731d911

netlify[bot] avatar Sep 26 '22 11:09 netlify[bot]

Related: https://github.com/cornerstonejs/cornerstone3D-beta/pull/224

Ouwen avatar Sep 26 '22 11:09 Ouwen

Codecov Report

Merging #2959 (405fa94) into v3-stable (9f1e813) will increase coverage by 14.48%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v3-stable    #2959       +/-   ##
==============================================
+ Coverage      25.15%   39.64%   +14.48%     
==============================================
  Files            119       96       -23     
  Lines           2862     2056      -806     
  Branches         555      427      -128     
==============================================
+ Hits             720      815       +95     
+ Misses          1856     1012      -844     
+ Partials         286      229       -57     
Impacted Files Coverage Δ
...tform/core/src/services/CineService/CineService.js 12.50% <0.00%> (-6.25%) :arrow_down:
...ore/src/services/_shared/pubSubServiceInterface.js 80.00% <0.00%> (-1.82%) :arrow_down:
.../services/MeasurementService/MeasurementService.js 48.03% <0.00%> (-1.15%) :arrow_down:
platform/core/src/classes/CommandsManager.js 90.69% <0.00%> (-1.14%) :arrow_down:
platform/core/src/classes/MetadataProvider.js 4.54% <0.00%> (-0.72%) :arrow_down:
platform/viewer/src/index.js 0.00% <0.00%> (ø)
platform/viewer/src/appInit.js 0.00% <0.00%> (ø)
platform/core/src/utils/index.js 100.00% <0.00%> (ø)
platform/core/src/utils/isImage.js 100.00% <0.00%> (ø)
platform/core/src/services/ServicesManager.js 100.00% <0.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4881ab...405fa94. Read the comment docs.

codecov[bot] avatar Sep 26 '22 11:09 codecov[bot]

@Ouwen Should we wait for other PRs regarding this to be merged first?

sedghi avatar Sep 28 '22 19:09 sedghi

Yeah I think it would make sense to do it all together.

Ouwen avatar Sep 29 '22 16:09 Ouwen