Frametimes - Auto

[Rayhan-011]

There are a few gaps in functionality that we need to add to the open source OHIF code:

1. The viewer needs the ability to load ultrasound cine and auto-play (without the user needing to press the play button). The framerate should be set automatically based on the stored frametime which is stored in the DICOM tag (0018,1063). See: https://github.com/OHIF/Viewers/blob/master/platform/ui/src/viewer/PlayClipButton.js

2. Also the animation should be smooth when frametimes are short. In the existing code, the animation is not smooth when frametimes are short (greater than 30fps). The code shoud instead set a resonable framerate (like less than 60fps) and then when animation frames are needed, calculate the proper frame based on actual elapsed time since the last frame. This would mean that the animation would play in real time even if the computer cannot process the frames fast enough. See: https://github.com/cornerstonejs/cornerstoneTools/blob/9ea015d9d8dbb2d1be43ca9c1f7d6bf61f153910/src/stackTools/playClip.js#L259

3. Reference lines should be displayed on the image. This is a feature that is currently not available in the open source OHIF code but is available in Cornerstone. https://tools.cornerstonejs.org/examples/tools/reference-lines.html

[codecov[bot]]

Codecov Report

Merging #2939 (5995b4e) into master (fe57c00) will decrease coverage by 0.74%. The diff coverage is 2.06%.

@@            Coverage Diff             @@
##           master    #2939      +/-   ##
==========================================
- Coverage   12.68%   11.93%   -0.75%     
==========================================
  Files         306      307       +1     
  Lines        8233     8456     +223     
  Branches     1593     1680      +87     
==========================================
- Hits         1044     1009      -35     
- Misses       5797     5959     +162     
- Partials     1392     1488      +96     

Impacted Files	Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js	2.63% <0.00%> (-0.76%)	:arrow_down:
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js	5.40% <ø> (ø)
.../DICOMSR/SCOORD3D/utils/getReferencedImagesList.js	6.25% <0.00%> (-0.90%)	:arrow_down:
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js	1.72% <0.00%> (-0.07%)	:arrow_down:
...orm/core/src/DICOMSR/parseDicomStructuredReport.js	7.50% <0.00%> (-1.60%)	:arrow_down:
platform/core/src/classes/HotkeysManager.js	76.66% <0.00%> (ø)
platform/core/src/classes/StudyLoadingListener.js	1.03% <0.00%> (+0.01%)	:arrow_up:
...latform/core/src/classes/metadata/StudyMetadata.js	1.25% <0.00%> (-0.04%)	:arrow_down:
.../core/src/measurements/tools/dicomSRDisplayTool.js	50.00% <0.00%> (ø)
.../src/studies/services/wado/studyInstanceHelpers.js	1.56% <0.00%> (-0.48%)	:arrow_down:
... and 29 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7e1d2c...5995b4e. Read the comment docs.

[Rayhan-011]

@horner can you please check this pull request - Thanks

[sedghi]

base has changed, read more here https://github.com/OHIF/Viewers/issues/3477

[sedghi]

we should investigate this in v3

[Rayhan-011]

we should investigate this in v3

I committed my code with functionality addition that you can use in V3

[sedghi]

Can you then maybe change the base to master?

[jbocce]

This PR is being closed in favour of this new PR https://github.com/OHIF/Viewers/pull/3735 which targets the most current master branch. Thanks @Rayhan-011 for the inspiration and ideas!