Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

[WIP] feat(context menu):Allow configurable context menus

Open wayfarer3130 opened this issue 3 years ago β€’ 5 comments

Example of how to add configurable context menus to OHIF. In the current sample, does not show any actual configuration uses, just allows for it.

wayfarer3130 avatar Aug 25 '22 22:08 wayfarer3130

Deploy Preview for ohif-platform-docs canceled.

Name Link
Latest commit 56268bf8615e08089ce3df02f7007c694422679c
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/641af0b3bb7f270008c66407

netlify[bot] avatar Aug 25 '22 22:08 netlify[bot]

@sedghi - this is an example of using the toolbar service to add other types of "toolbars" - in this case, right click context menus. We can use this as a straw man next week for our discussion. I'm also going to try to get a second example of overlay configuration.

wayfarer3130 avatar Aug 25 '22 22:08 wayfarer3130

Deploy Preview for ohif-platform-viewer canceled.

Name Link
Latest commit 56268bf8615e08089ce3df02f7007c694422679c
Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/641af0b339110300078eba73

netlify[bot] avatar Aug 25 '22 22:08 netlify[bot]

Codecov Report

Merging #2894 (56268bf) into v3-stable (9f1e813) will increase coverage by 12.64%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v3-stable    #2894       +/-   ##
==============================================
+ Coverage      25.15%   37.80%   +12.64%     
==============================================
  Files            119       85       -34     
  Lines           2862     1386     -1476     
  Branches         555      305      -250     
==============================================
- Hits             720      524      -196     
+ Misses          1856      695     -1161     
+ Partials         286      167      -119     

see 76 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 3b6822e...56268bf. Read the comment docs.

codecov[bot] avatar Aug 25 '22 22:08 codecov[bot]

Passing run #3046 β†—οΈŽ

0 34 0 0 Flakiness 0

Details:

Add chevron right to the sub-menus
Project: Viewers Commit: 56268bf861
Status: Passed Duration: 03:22 πŸ’‘
Started: Mar 22, 2023 12:19 PM Ended: Mar 22, 2023 12:22 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Aug 25 '22 22:08 cypress[bot]