Updates/rayhan

[Rayhan-011]

PR Checklist

• [x] Brief description of changes
• [x] Links to any relevant issues
• [x] Required status checks are passing
• [x] User cases if changes impact the user's experience
• [x] @mention a maintainer to request a review

[codecov[bot]]

Codecov Report

Merging #2886 (b34403d) into master (fe57c00) will decrease coverage by 0.28%. The diff coverage is 1.98%.

@@            Coverage Diff             @@
##           master    #2886      +/-   ##
==========================================
- Coverage   12.68%   12.39%   -0.29%     
==========================================
  Files         306      307       +1     
  Lines        8233     8428     +195     
  Branches     1593     1670      +77     
==========================================
+ Hits         1044     1045       +1     
- Misses       5797     5914     +117     
- Partials     1392     1469      +77     

Impacted Files	Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js	2.66% <0.00%> (-0.73%)	:arrow_down:
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js	5.40% <ø> (ø)
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js	1.72% <0.00%> (-0.07%)	:arrow_down:
platform/core/src/classes/StudyLoadingListener.js	1.02% <0.00%> (ø)
...latform/core/src/classes/metadata/StudyMetadata.js	1.26% <0.00%> (-0.03%)	:arrow_down:
.../core/src/measurements/tools/dicomSRDisplayTool.js	50.00% <0.00%> (ø)
...m/core/src/utils/loadAndCacheDerivedDisplaySets.js	0.00% <0.00%> (ø)
...ons/MeasurementsPanel/ConnectedMeasurementTable.js	0.00% <ø> (ø)
...c/components/ViewportGrid/ConnectedViewportGrid.js	0.00% <0.00%> (ø)
...viewer/src/components/ViewportGrid/ViewportGrid.js	0.00% <0.00%> (ø)
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efdbe8e...b34403d. Read the comment docs.

[Rayhan-011]

1. The viewer needs the ability to load ultrasound cine and auto-play (without the user needing to press the play button). The framerate should be set automatically based on the stored frame time in the DICOM tag (0018,1063). See: https://github.com/OHIF/Viewers/blob/master/platform/ui/src/viewer/PlayClipButton.js

2. Also the animation should be smooth when frame times are short. In the existing code, the animation is not smooth when frame times are short (greater than 30fps). The code should instead set a reasonable framerate (like less than 60fps) and then when animation frames are needed, calculate the proper frame based on the actual elapsed time since the last frame. This would mean that the animation would play in real time even if the computer cannot process the frames fast enough. See: https://github.com/cornerstonejs/cornerstoneTools/blob/9ea015d9d8dbb2d1be43ca9c1f7d6bf61f153910/src/stackTools/playClip.js#L259

3. Reference lines should be displayed on the image. This feature is currently not available in the open source OHIF code but is available in Cornerstone. https://tools.cornerstonejs.org/examples/tools/reference-lines.html

[sedghi]

base has changed, read more here https://github.com/OHIF/Viewers/issues/3477