Viewers
Viewers copied to clipboard
Fixed framerate in the player defaults to the framerate in the series
Codecov Report
Merging #2883 (1bfd8ad) into master (fe57c00) will decrease coverage by
0.74%. The diff coverage is2.07%.
@@ Coverage Diff @@
## master #2883 +/- ##
==========================================
- Coverage 12.68% 11.93% -0.75%
==========================================
Files 306 307 +1
Lines 8233 8453 +220
Branches 1593 1683 +90
==========================================
- Hits 1044 1009 -35
- Misses 5797 5953 +156
- Partials 1392 1491 +99
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js | 2.63% <0.00%> (-0.76%) |
:arrow_down: |
| .../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js | 5.40% <ø> (ø) |
|
| ...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js | 1.72% <0.00%> (-0.07%) |
:arrow_down: |
| platform/core/src/classes/StudyLoadingListener.js | 1.03% <0.00%> (+0.01%) |
:arrow_up: |
| platform/core/src/classes/StudyPrefetcher.js | 0.67% <0.00%> (-0.02%) |
:arrow_down: |
| ...latform/core/src/classes/metadata/StudyMetadata.js | 1.25% <0.00%> (-0.04%) |
:arrow_down: |
| .../core/src/measurements/tools/dicomSRDisplayTool.js | 50.00% <0.00%> (ø) |
|
| .../src/studies/services/wado/studyInstanceHelpers.js | 1.56% <0.00%> (-0.48%) |
:arrow_down: |
| platform/core/src/utils/StackManager.js | 11.62% <0.00%> (ø) |
|
| ...m/core/src/utils/loadAndCacheDerivedDisplaySets.js | 0.00% <0.00%> (ø) |
|
| ... and 24 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ddfde92...1bfd8ad. Read the comment docs.
Watch https://www.youtube.com/watch?v=QyyXQaXOWr0
@horner Is this PR finalized for another round of review?
base has changed, read more here https://github.com/OHIF/Viewers/issues/3477
we should investigate this in v3
This PR is being closed in favour of this new PR https://github.com/OHIF/Viewers/pull/3735 which targets the most current master branch. Thanks @horner and @rareramos for the inspiration and ideas.