Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

Fixed framerate in the player defaults to the framerate in the series

Open horner opened this issue 3 years ago • 2 comments

Screen Shot 2022-08-21 at 11 03 28 AM

horner avatar Aug 21 '22 15:08 horner

Codecov Report

Merging #2883 (1bfd8ad) into master (fe57c00) will decrease coverage by 0.74%. The diff coverage is 2.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2883      +/-   ##
==========================================
- Coverage   12.68%   11.93%   -0.75%     
==========================================
  Files         306      307       +1     
  Lines        8233     8453     +220     
  Branches     1593     1683      +90     
==========================================
- Hits         1044     1009      -35     
- Misses       5797     5953     +156     
- Partials     1392     1491      +99     
Impacted Files Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js 2.63% <0.00%> (-0.76%) :arrow_down:
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js 5.40% <ø> (ø)
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js 1.72% <0.00%> (-0.07%) :arrow_down:
platform/core/src/classes/StudyLoadingListener.js 1.03% <0.00%> (+0.01%) :arrow_up:
platform/core/src/classes/StudyPrefetcher.js 0.67% <0.00%> (-0.02%) :arrow_down:
...latform/core/src/classes/metadata/StudyMetadata.js 1.25% <0.00%> (-0.04%) :arrow_down:
.../core/src/measurements/tools/dicomSRDisplayTool.js 50.00% <0.00%> (ø)
.../src/studies/services/wado/studyInstanceHelpers.js 1.56% <0.00%> (-0.48%) :arrow_down:
platform/core/src/utils/StackManager.js 11.62% <0.00%> (ø)
...m/core/src/utils/loadAndCacheDerivedDisplaySets.js 0.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ddfde92...1bfd8ad. Read the comment docs.

codecov[bot] avatar Aug 21 '22 15:08 codecov[bot]

Watch https://www.youtube.com/watch?v=QyyXQaXOWr0

image

horner avatar Sep 05 '22 05:09 horner

@horner Is this PR finalized for another round of review?

sedghi avatar Nov 10 '22 18:11 sedghi

base has changed, read more here https://github.com/OHIF/Viewers/issues/3477

sedghi avatar Jun 19 '23 13:06 sedghi

we should investigate this in v3

sedghi avatar Oct 04 '23 16:10 sedghi

This PR is being closed in favour of this new PR https://github.com/OHIF/Viewers/pull/3735 which targets the most current master branch. Thanks @horner and @rareramos for the inspiration and ideas.

jbocce avatar Oct 18 '23 19:10 jbocce