Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

fix(cli):Mode create wasn't quite working correctly.

Open wayfarer3130 opened this issue 2 years ago β€’ 4 comments

The cli wasn't creating modes or extensions that were quite buildable.

wayfarer3130 avatar Aug 12 '22 13:08 wayfarer3130

Deploy Preview for ohif-platform-viewer ready!

Name Link
Latest commit f3e4d7075d8db149971feff1ee7c848103dcfd4d
Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/62f652839a2ab2000a7338ba
Deploy Preview https://deploy-preview-2868--ohif-platform-viewer.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 12 '22 13:08 netlify[bot]

Deploy Preview for ohif-platform-docs canceled.

Name Link
Latest commit f3e4d7075d8db149971feff1ee7c848103dcfd4d
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/62f65283b12f870008443149

netlify[bot] avatar Aug 12 '22 13:08 netlify[bot]

Codecov Report

Merging #2868 (f3e4d70) into v3-stable (9f1e813) will increase coverage by 5.72%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           v3-stable    #2868      +/-   ##
=============================================
+ Coverage      25.15%   30.88%   +5.72%     
=============================================
  Files            119      103      -16     
  Lines           2862     2270     -592     
  Branches         555      447     -108     
=============================================
- Hits             720      701      -19     
+ Misses          1856     1289     -567     
+ Partials         286      280       -6     
Impacted Files Coverage Ξ”
...tform/core/src/services/CineService/CineService.js 12.50% <0.00%> (-6.25%) :arrow_down:
.../services/HangingProtocolService/ProtocolEngine.js 0.00% <0.00%> (-2.18%) :arrow_down:
.../services/MeasurementService/MeasurementService.js 47.23% <0.00%> (-1.96%) :arrow_down:
platform/core/src/classes/CommandsManager.js 90.69% <0.00%> (-1.14%) :arrow_down:
...e/src/services/HangingProtocolService/HPMatcher.js 6.89% <0.00%> (-0.80%) :arrow_down:
...s/HangingProtocolService/HangingProtocolService.js 0.63% <0.00%> (-0.76%) :arrow_down:
platform/core/src/classes/MetadataProvider.js 4.72% <0.00%> (-0.54%) :arrow_down:
...core/src/services/ToolBarService/ToolBarService.js 1.36% <0.00%> (-0.13%) :arrow_down:
platform/viewer/src/index.js 0.00% <0.00%> (ΓΈ)
platform/viewer/src/appInit.js 0.00% <0.00%> (ΓΈ)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ae897c4...f3e4d70. Read the comment docs.

codecov[bot] avatar Aug 12 '22 13:08 codecov[bot]



Test summary

20 β€’ 0 β€’ 0 β€’ 0


Run details

Project Viewers
Status Passed
Commit f3e4d7075d
Started Aug 12, 2022 1:21 PM
Ended Aug 12, 2022 1:22 PM
Duration 01:18 πŸ’‘
OS Linux Debian - 10.9
Browser Chrome 88

View run in Cypress Dashboard ➑️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 12 '22 13:08 cypress[bot]

I don't think we need this any more

sedghi avatar Aug 19 '22 22:08 sedghi