Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

Instance-level qualitative annotations not handled properly when there is more than one SR

Open fedorov opened this issue 2 years ago • 1 comments

It appears that if 2 SR instances with slice-level qualitative annotations are present, it is impossible to select the active one in the right-hand panel, and also there appears to be no labels with the annotations in the slice view.

@deepakri201 can share an example dataset.

Follow up on https://github.com/OHIF/Viewers/issues/2797

fedorov avatar Jul 28 '22 21:07 fedorov

It seems that the annotations only appear for one of the SR instances.

Here is an example dataset

deepakri201 avatar Jul 28 '22 21:07 deepakri201

@Punzo thanks for the quick fix! Can you maybe give a brief summary what was the underlying issue?

fedorov avatar Aug 24 '22 13:08 fedorov

@Punzo thanks for the quick fix! Can you maybe give a brief summary what was the underlying issue?

just an error in the parsing code, the second SR was overwriting the read data of the first, instead of appending.

I also fixed a couple of very minor issues in the UI

Punzo avatar Aug 24 '22 18:08 Punzo

Thank you for the fix! Unfortunately, I think there may be a problem as I get the following error:

image

Here is a dropbox link the with the 2 SRs and the corresponding CT data.

I also noticed that in /platform/viewer/public/config/default.js, v9 is referenced. Could it be changed to v10?

Thanks!

deepakri201 avatar Aug 24 '22 23:08 deepakri201

I also noticed that in /platform/viewer/public/config/default.js, v9 is referenced. Could it be changed to v10?

sure! done!

Here is a dropbox link the with the 2 SRs and the corresponding CT data.

ok I will check it out now

Punzo avatar Aug 25 '22 07:08 Punzo

@deepakri201 for me both datasets are working: 1) Screenshot from 2022-08-25 09-59-36 2) Screenshot from 2022-08-25 10-00-06

However, In your screenshot I see a study with a segmentation and two SRs, but no CT data (while I have in both data test 1 CT and 2 SR). Probably it is related to pointing v9 vs v10 release in the config. Can you please double check if v10 release has fixed the issue? Thanks

Punzo avatar Aug 25 '22 08:08 Punzo

Hi,

Thanks for taking a look -- I should have mentioned that I'm using this branch: https://github.com/ImagingDataCommons/Viewers/tree/IDC2servers

I realized that I made a mistake in how I was deploying our OHIF instance, once I fixed that, everything looks great :)

image

Thanks again!

deepakri201 avatar Aug 25 '22 16:08 deepakri201