Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

Make hanging protocol work on display sets instead of series

Open wayfarer3130 opened this issue 2 years ago • 4 comments

Fixes numerous issues causing real hanging protocols to not be definable or not work as expected, or work intermittently.

wayfarer3130 avatar Jul 06 '22 19:07 wayfarer3130

Codecov Report

Merging #2837 (787bb43) into v3-stable (9f1e813) will increase coverage by 12.35%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v3-stable    #2837       +/-   ##
==============================================
+ Coverage      25.15%   37.51%   +12.35%     
==============================================
  Files            119      102       -17     
  Lines           2862     2146      -716     
  Branches         555      438      -117     
==============================================
+ Hits             720      805       +85     
+ Misses          1856     1099      -757     
+ Partials         286      242       -44     
Impacted Files Coverage Δ
...tform/core/src/services/CineService/CineService.js 12.50% <0.00%> (-6.25%) :arrow_down:
.../services/MeasurementService/MeasurementService.js 47.23% <0.00%> (-1.96%) :arrow_down:
platform/core/src/classes/CommandsManager.js 90.69% <0.00%> (-1.14%) :arrow_down:
platform/core/src/classes/MetadataProvider.js 4.72% <0.00%> (-0.54%) :arrow_down:
...core/src/services/ToolBarService/ToolBarService.js 1.36% <0.00%> (-0.13%) :arrow_down:
platform/viewer/src/index.js 0.00% <0.00%> (ø)
platform/viewer/src/appInit.js 0.00% <0.00%> (ø)
platform/core/src/utils/index.js 100.00% <0.00%> (ø)
platform/core/src/DataSources/IWebApiDataSource.js 11.11% <0.00%> (ø)
...services/DicomMetadataStore/createStudyMetadata.js 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2639d90...787bb43. Read the comment docs.

codecov[bot] avatar Jul 06 '22 19:07 codecov[bot]



Test summary

20 0 0 0


Run details

Project Viewers
Status Passed
Commit 787bb43054
Started Sep 7, 2022 3:53 PM
Ended Sep 7, 2022 3:55 PM
Duration 01:53 💡
OS Linux Debian - 11.3
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Jul 06 '22 19:07 cypress[bot]

Deploy Preview for ohif-platform-viewer ready!

Name Link
Latest commit 787bb4305425a3c3a473a9da20c50a368945cd70
Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/6318bcb509a913000832b543
Deploy Preview https://deploy-preview-2837--ohif-platform-viewer.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 04 '22 16:08 netlify[bot]

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit 787bb4305425a3c3a473a9da20c50a368945cd70
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6318bcb5190af700080403f1
Deploy Preview https://deploy-preview-2837--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 04 '22 16:08 netlify[bot]