Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

Fix window preset and thumbnail list

Open salimkanoun opened this issue 2 years ago • 3 comments

This PR is a new PR corresponding to #2808 and #2798 solving the display issue of series thumnail and inverted preset for Bone and Brain CT windowing.

I made this new PR because the #2808 was missing edition in the default value of preset.

Solves #2796 #2807 Replace #2808 #2798

Discussed with @swederik few weeks ago

salimkanoun avatar Jun 18 '22 13:06 salimkanoun

Codecov Report

Merging #2826 (2449f06) into feat/cornerstone3D (096924b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/cornerstone3D    #2826   +/-   ##
===================================================
  Coverage               30.88%   30.88%           
===================================================
  Files                     103      103           
  Lines                    2270     2270           
  Branches                  447      447           
===================================================
  Hits                      701      701           
  Misses                   1289     1289           
  Partials                  280      280           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 096924b...2449f06. Read the comment docs.

codecov[bot] avatar Jun 18 '22 13:06 codecov[bot]

Hi @salimkanoun , I commented on the issue I noticed with the UI here https://github.com/OHIF/Viewers/pull/2798#issuecomment-1192000459

sedghi avatar Jul 21 '22 22:07 sedghi

hi @sedghi i made the change here because I think @Celian-abd has deleted his branch meanwhile (and on holidays for now)

salimkanoun avatar Jul 21 '22 22:07 salimkanoun

replaced by #2877

salimkanoun avatar Aug 18 '22 23:08 salimkanoun