Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

fixed variant PropTypes is undefined and SeriesNumber type is Number bug

Open 027xiguapi opened this issue 2 years ago • 6 comments

…mber bug

PR Checklist

  • [ ] Brief description of changes
  • [ ] Links to any relevant issues
  • [ ] Required status checks are passing
  • [ ] User cases if changes impact the user's experience
  • [ ] @mention a maintainer to request a review

027xiguapi avatar May 05 '22 08:05 027xiguapi

Deploy Preview for ohif-platform-docs canceled.

Name Link
Latest commit 79774be73bcade3205f99894cdf7638458c3f9dc
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/62ecbe0538050f0009e84feb

netlify[bot] avatar May 05 '22 08:05 netlify[bot]

Deploy Preview for ohif-platform-viewer ready!

Name Link
Latest commit 79774be73bcade3205f99894cdf7638458c3f9dc
Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/62ecbe0584989e0009e54bef
Deploy Preview https://deploy-preview-2793--ohif-platform-viewer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 05 '22 08:05 netlify[bot]

Codecov Report

Merging #2793 (5580338) into v3-stable (9f1e813) will increase coverage by 0.15%. The diff coverage is 2.56%.

:exclamation: Current head 5580338 differs from pull request most recent head 79774be. Consider uploading reports for the commit 79774be to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##           v3-stable    #2793      +/-   ##
=============================================
+ Coverage      25.15%   25.31%   +0.15%     
=============================================
  Files            119      120       +1     
  Lines           2862     2868       +6     
  Branches         555      562       +7     
=============================================
+ Hits             720      726       +6     
+ Misses          1856     1849       -7     
- Partials         286      293       +7     
Impacted Files Coverage Δ
platform/core/src/DataSources/IWebApiDataSource.js 11.11% <ø> (ø)
platform/core/src/classes/MetadataProvider.js 5.26% <ø> (ø)
platform/core/src/utils/index.js 100.00% <ø> (ø)
...tadataProvider/fetchPaletteColorLookupTableData.js 0.00% <0.00%> (ø)
platform/viewer/src/App.jsx 0.00% <0.00%> (ø)
platform/viewer/src/appInit.js 0.00% <0.00%> (ø)
platform/viewer/src/index.js 0.00% <ø> (ø)
platform/viewer/src/routes/Mode/Mode.jsx 0.00% <0.00%> (ø)
platform/viewer/src/routes/PrivateRoute.jsx 0.00% <0.00%> (ø)
platform/viewer/src/routes/WorkList/WorkList.jsx 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f0ad6f...79774be. Read the comment docs.

codecov[bot] avatar May 05 '22 08:05 codecov[bot]

ok,I have solved it

027xiguapi avatar Aug 05 '22 06:08 027xiguapi

Can you rebase please?

sedghi avatar Aug 05 '22 15:08 sedghi

Yes, check it

027xiguapi avatar Aug 08 '22 00:08 027xiguapi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '23 07:06 stale[bot]

Hey, thanks for updating it. You can change your based to master since we merged v3-stable to master. Also you need to pull in new updates since we changed the signiture of buttons

sedghi avatar Jun 19 '23 11:06 sedghi