Not able to display PatientName or InstitutionName within in the "ideographic" part of the DICOM tag "00100010"

[felixlinxk]

Before Creating an issue

• Are you running the latest version? Yes
• Are you reporting to the correct repository? Yes
• Did you search existing issues? Yes, but no resolution was found.

Bug Report

Describe the Bug

Both StudyList and Viewer are not able to display PatientName or InstitutionName as long as the SpecificCharacterSet is GB18030, which is a very common character set when it comes to Chinese characters. Besides, the PatientName and InstitutionName are showing "(empty)", no matter whether the input is In Chinese or not.

A sample DICOM file is provided at the description of bug reproduction.

What steps can we follow to reproduce the bug?

1. First step upload a dicom file with SpecificCharacterSet set to GB18030, then viola!

This is a sample DICOM file with SpecificCharacterSet being GB18030, for who wants to test this, you can download it and have a try. sample DICOM with SpecificCharacterSet being GB18030.zip

If you never heard of GB18030 before, this is an illustration of the compatibility of several Chinese codes.

Wait.... I kinda know the reason why... It seems like OHIF only reads and display the "Alphabetic" part of the PN, and ignoring the "ideographic" part which includes Chinese characters of course. The contents of "ideographic" are Unicode encoding for Chinese characters.

update...

I've found out that in those DICOM files which can be displayed normally, the chinese characters were recorded within the "Alphabetic" part of the PN value. Maybe this information can help solving this bug?

:warning: Reports we cannot reproduce are at risk of being marked stale and closed. The more information you can provide, the more likely we are to look into and address your issue.

[felixlinxk]

Here is what I've done to the getName.js

and problem solved!

[bonviesinfo]

hi could you show other information about modifing code Value not contain the ideographic word.

[felixlinxk]

You can simply add more or modify if statements in the getName.js accordingly.

[bonviesinfo]

hi you only add the ideographic code and solve the problem?

[sedghi]

Please review the latest code in the master branch. This issue might have been resolved. If it persists, kindly reopen the issue with updated details.

Try viewer-dev.ohif.org instead of viewer.ohif.org Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master branch Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing