Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

Update dicom loader service to load rt json

Open igoroctaviano opened this issue 3 years ago • 3 comments

  • Rename dataset references to displaySet inside the dicomLoaderService to avoid confusion.
  • Add a check to getReferencedDisplaySet to avoid runtime errors.
  • Update getImageInstance to get instance from study metadata instead of displaySet object.

igoroctaviano avatar Jan 25 '22 22:01 igoroctaviano

Codecov Report

Merging #2690 (a4f86c5) into v2-legacy (5109db6) will decrease coverage by 0.02%. The diff coverage is 5.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           v2-legacy    #2690      +/-   ##
=============================================
- Coverage      11.93%   11.92%   -0.02%     
=============================================
  Files            306      306              
  Lines           8443     8451       +8     
  Branches        1678     1679       +1     
=============================================
  Hits            1008     1008              
- Misses          5949     5956       +7     
- Partials        1486     1487       +1     
Files Coverage Δ
platform/core/src/utils/dicomLoaderService.js 10.63% <5.00%> (-0.99%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5109db6...a4f86c5. Read the comment docs.

codecov[bot] avatar Jan 25 '22 23:01 codecov[bot]

1 failed test on run #3681 ↗︎

1 75 0 0 Flakiness 0

Details:

Remove folder
Project: Viewers Commit: a4f86c5dee
Status: Failed Duration: 05:51 💡
Started: Dec 7, 2023 9:22 PM Ended: Dec 7, 2023 9:28 PM
Failed  cypress/integration/pwa/OHIFLoadLocalPDFFile.spec.js • 1 failed test

View Output

Test Artifacts
OHIF Load Local PDF File > loads a PDF DICOM file and visualize it Screenshots

Review all test suite changes for PR #2690 ↗︎

cypress[bot] avatar Jan 25 '22 23:01 cypress[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 06:07 stale[bot]

base has changed, read more here https://github.com/OHIF/Viewers/issues/3477

sedghi avatar Jun 19 '23 13:06 sedghi

@igoroctaviano is this valid in v3?

sedghi avatar Oct 04 '23 16:10 sedghi

Deploy Preview for viewer-v2-legacy ready!

Name Link
Latest commit a4f86c5dee3d9d0e54df8522c3a7285b3cd9a305
Latest deploy log https://app.netlify.com/sites/viewer-v2-legacy/deploys/657235e64e61860008f6789b
Deploy Preview https://deploy-preview-2690--viewer-v2-legacy.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 07 '23 21:12 netlify[bot]

@igoroctaviano is this valid in v3?

I wouldn't worry about this in v3 but for v2 its valid. Feel free to merge it or close it.

igoroctaviano avatar Dec 07 '23 21:12 igoroctaviano