Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

wip: Debug frozen drag drop - for deploy preview

Open swederik opened this issue 3 years ago • 3 comments

PR Checklist

  • [ ] Brief description of changes
  • [ ] Links to any relevant issues
  • [ ] Required status checks are passing
  • [ ] User cases if changes impact the user's experience
  • [ ] @mention a maintainer to request a review

swederik avatar Oct 01 '21 13:10 swederik

Codecov Report

Merging #2573 (9fd0d66) into master (f8740e0) will decrease coverage by 0.08%. The diff coverage is 4.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2573      +/-   ##
==========================================
- Coverage   13.33%   13.25%   -0.09%     
==========================================
  Files         288      289       +1     
  Lines        7664     7757      +93     
  Branches     1465     1494      +29     
==========================================
+ Hits         1022     1028       +6     
- Misses       5378     5435      +57     
- Partials     1264     1294      +30     
Impacted Files Coverage Δ
platform/core/src/classes/index.js 100.00% <ø> (ø)
...latform/core/src/classes/metadata/StudyMetadata.js 1.31% <0.00%> (-0.02%) :arrow_down:
platform/core/src/redux/actions.js 86.66% <ø> (-1.57%) :arrow_down:
platform/core/src/redux/reducers/index.js 100.00% <ø> (ø)
...tform/viewer/src/components/StudyLoadingMonitor.js 0.00% <0.00%> (ø)
platform/viewer/src/components/StudyPrefetcher.js 0.00% <0.00%> (ø)
...r/src/connectedComponents/ConnectedStudyBrowser.js 0.00% <0.00%> (ø)
...rc/connectedComponents/ConnectedStudyPrefetcher.js 0.00% <0.00%> (ø)
platform/viewer/src/connectedComponents/Viewer.js 0.00% <0.00%> (ø)
platform/core/src/classes/StudyPrefetcher.js 0.71% <1.61%> (+0.71%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 252536a...9fd0d66. Read the comment docs.

codecov[bot] avatar Oct 01 '21 13:10 codecov[bot]



Test summary

49 2 0 26


Run details

Project Viewers
Status Failed
Commit 9fd0d66c59
Started Oct 1, 2021 2:58 PM
Ended Oct 1, 2021 3:06 PM
Duration 07:46 💡
OS Linux Debian - 10.6
Browser Chrome 86

View run in Cypress Dashboard ➡️


Failures

OHIFCornerstoneToolbar.spec.js Failed
1 OHIF Cornerstone Toolbar > checks if all primary buttons are being displayed
OHIFStudyViewer.spec.js Failed
1 OHIF Study Viewer Page > checks if series thumbnails are being displayed

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Oct 01 '21 13:10 cypress[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 12:07 stale[bot]

base has changed, read more here https://github.com/OHIF/Viewers/issues/3477

sedghi avatar Jun 19 '23 13:06 sedghi