Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

fix: ImageThumbnail useEffect function dependencies should be wrapped in useCallback

Open PoyangLiu opened this issue 3 years ago • 2 comments

This fixes a problem described in OHIF-2443

  • add useCallback with proper dependencies to ImageThumbnail.js fetchImagePromise, setImagePromise and purgeCancelablePromise

@swederik

PoyangLiu avatar Jun 07 '21 18:06 PoyangLiu

Codecov Report

Merging #2444 (9e04a89) into master (1e72684) will decrease coverage by 0.04%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2444      +/-   ##
==========================================
- Coverage   13.20%   13.15%   -0.05%     
==========================================
  Files         289      289              
  Lines        7816     7845      +29     
  Branches     1510     1510              
==========================================
  Hits         1032     1032              
- Misses       5474     5503      +29     
  Partials     1310     1310              
Impacted Files Coverage Δ
platform/core/src/classes/StudyPrefetcher.js 0.69% <0.00%> (-0.03%) :arrow_down:
...latform/core/src/classes/metadata/StudyMetadata.js 1.29% <0.00%> (-0.02%) :arrow_down:
...form/core/src/utils/isDisplaySetReconstructable.js 3.37% <0.00%> (ø)
...r/src/connectedComponents/ConnectedStudyBrowser.js 0.00% <0.00%> (ø)
platform/viewer/src/connectedComponents/Viewer.js 0.00% <0.00%> (ø)
...tform/viewer/src/connectedComponents/ViewerMain.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23376d2...9e04a89. Read the comment docs.

codecov[bot] avatar Jun 07 '21 18:06 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 12:07 stale[bot]