Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

Bugfix UI dialog footer

Open jasonshea opened this issue 4 years ago • 2 comments

PR Checklist

  • [ ] Brief description of changes
  1. There is an overflow in the dialog footer.
  2. On the Annotation dialog the Confirm button text is black and should be white. Incorrect CSS class was used.

image

image

  • [ ] Links to any relevant issues - None
  • [ ] Required status checks are passing
  • [ ] User cases if changes impact the user's experience - None
  • [ ] @mention a maintainer to request a review - None

jasonshea avatar Apr 11 '21 16:04 jasonshea

Codecov Report

Merging #2355 (1651737) into master (1e72684) will decrease coverage by 0.05%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2355      +/-   ##
==========================================
- Coverage   13.20%   13.14%   -0.06%     
==========================================
  Files         289      289              
  Lines        7816     7849      +33     
  Branches     1510     1512       +2     
==========================================
  Hits         1032     1032              
- Misses       5474     5505      +31     
- Partials     1310     1312       +2     
Impacted Files Coverage Δ
platform/core/src/classes/StudyLoadingListener.js 1.02% <0.00%> (ø)
platform/core/src/classes/StudyPrefetcher.js 0.69% <0.00%> (-0.03%) :arrow_down:
...latform/core/src/classes/metadata/StudyMetadata.js 1.29% <0.00%> (-0.02%) :arrow_down:
.../src/studies/services/wado/studyInstanceHelpers.js 2.04% <0.00%> (-0.19%) :arrow_down:
...form/core/src/utils/isDisplaySetReconstructable.js 3.37% <0.00%> (ø)
...r/src/connectedComponents/ConnectedStudyBrowser.js 0.00% <0.00%> (ø)
platform/viewer/src/connectedComponents/Viewer.js 0.00% <0.00%> (ø)
...tform/viewer/src/connectedComponents/ViewerMain.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7ba2fa...1651737. Read the comment docs.

codecov[bot] avatar Apr 11 '21 16:04 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 12:07 stale[bot]

base has changed, read more here https://github.com/OHIF/Viewers/issues/3477

sedghi avatar Jun 19 '23 13:06 sedghi