Viewers
Viewers copied to clipboard
Fix Sort by Date
PR Checklist
- [x] Brief description of changes Change _sortStudies Function on StudyListRoute.js, right now sort by date is not working because first changes date format and after that try to sort, i only move the format of the date after the sort of the studies array
- [x] Links to any relevant issues https://github.com/OHIF/Viewers/pull/1972 https://github.com/OHIF/Viewers/pull/1973
- [ ] Required status checks are passing
- [ ] User cases if changes impact the user's experience
- [ ]
@mentiona maintainer to request a review
Codecov Report
Merging #2285 (2648fbd) into master (cfd66e5) will decrease coverage by
0.00%. The diff coverage is0.00%.
@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
- Coverage 13.61% 13.61% -0.01%
==========================================
Files 284 284
Lines 7394 7395 +1
Branches 1394 1394
==========================================
Hits 1007 1007
- Misses 5187 5188 +1
Partials 1200 1200
| Impacted Files | Coverage Δ | |
|---|---|---|
| platform/viewer/src/studylist/StudyListRoute.js | 0.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 59cadad...2648fbd. Read the comment docs.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
I cannot reproduce this anymore on master. I know it has been a long time, but can you check if it still applies?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
base has changed, read more here https://github.com/OHIF/Viewers/issues/3477