Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

feat: Add togglable button for synchronized scrolling by stack image p…

Open swederik opened this issue 4 years ago • 5 comments

…osition

PR Checklist

  • [ ] Brief description of changes
  • [ ] Links to any relevant issues
  • [ ] Required status checks are passing
  • [ ] User cases if changes impact the user's experience
  • [ ] @mention a maintainer to request a review

@salimkanoun

swederik avatar Nov 16 '20 08:11 swederik

@swederik Amazing! I tried it with MRI and PET/CT, it works very well !

Is there a settings I can use in the app-config.js to auto-enable this scroll sync for all users ?

salimkanoun avatar Nov 16 '20 09:11 salimkanoun

@swederik if i'm correct you linked the viewer with the already existing sycing tool in cornerstone tools. I see that cornestone tools has also a pan / zoom sync available in the source code. If I follow this commit change, do you think I can expose the pan / zoom sync the same way you did for the sync scroll ?

salimkanoun avatar Nov 16 '20 10:11 salimkanoun

Hi @swederik ,

I also like this feature. I have tested it and i found dat if you have like two transversal views and a sagital view and you sync the transversal ones the sagital jumps back to its first slice is there a way to fix this?

Kind regards,

Najim

najimhashgraph avatar Mar 22 '21 12:03 najimhashgraph

This works very well even on top of current master.

Some radiologists might want to sync based on different offsets, so maybe it should not scroll to the same base index position, but with regards to the state it found though ? Or potentially make this behavior optional ?

matthiasg avatar Jun 04 '21 06:06 matthiasg

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 12:07 stale[bot]

https://github.com/OHIF/Viewers/issues/3477

sedghi avatar Jun 19 '23 13:06 sedghi

@swederik , geate job. do you have this for version 3?

fmotta1968 avatar Aug 29 '23 14:08 fmotta1968

we have that in master right now.

Try viewer-dev.ohif.org instead of viewer.ohif.org Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master branch Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing

sedghi avatar Oct 04 '23 15:10 sedghi