Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

fix docker-compose and dockerfile for keycloak

Open toj11001 opened this issue 5 years ago • 7 comments

PR Checklist

  • [x] Brief description of changes
  • [x] Links to any relevant issues
  • [x] Required status checks are passing
  • [ ] User cases if changes impact the user's experience
  • [x] @mention a maintainer to request a review

Description

I updated the docker-compose and the dockerfile for the Orthanc Keycloak recipe to the new folder structure since it wasn't working in the current state. For the dockerfile build stage I took almost everything over from the root Dockerfile which was work and in the deployment stage I kept the openresty config and only update the path to the static output files from the build.

This should also solve the build problems from #1757, but the whole setup still isn't working yet. I can can get a token for the viewer at localhost/ but when going to /pacs the nginx throws an error, which I'm not sure about yet.

accessing discovery url (http://localhost/auth/realms/ohif/.well-known/openid-configuration) failed: localhost could not be resolved (3: Host not found)

Could you please have a look at my changes @dannyrb and any thoughts why I get the error message for the secured routes?

Cheers!

toj11001 avatar Sep 18 '20 23:09 toj11001

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 12 '20 16:10 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 28 '20 08:11 stale[bot]

Codecov Report

Merging #2050 (a238be2) into master (fe57c00) will decrease coverage by 0.28%. The diff coverage is 2.03%.

:exclamation: Current head a238be2 differs from pull request most recent head 621342a. Consider uploading reports for the commit 621342a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
- Coverage   12.68%   12.40%   -0.28%     
==========================================
  Files         306      307       +1     
  Lines        8233     8422     +189     
  Branches     1593     1669      +76     
==========================================
+ Hits         1044     1045       +1     
- Misses       5797     5909     +112     
- Partials     1392     1468      +76     
Impacted Files Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js 2.63% <0.00%> (-0.76%) :arrow_down:
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js 5.40% <ø> (ø)
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js 1.72% <0.00%> (-0.07%) :arrow_down:
platform/core/src/classes/StudyLoadingListener.js 1.02% <0.00%> (ø)
...latform/core/src/classes/metadata/StudyMetadata.js 1.26% <0.00%> (-0.03%) :arrow_down:
.../core/src/measurements/tools/dicomSRDisplayTool.js 50.00% <0.00%> (ø)
...m/core/src/utils/loadAndCacheDerivedDisplaySets.js 0.00% <0.00%> (ø)
...ons/MeasurementsPanel/ConnectedMeasurementTable.js 0.00% <ø> (ø)
...c/appExtensions/MeasurementsPanel/jumpToRowItem.js 0.00% <0.00%> (ø)
...r/src/connectedComponents/ConnectedStudyBrowser.js 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30515b8...621342a. Read the comment docs.

codecov[bot] avatar Dec 06 '20 14:12 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '21 02:06 stale[bot]

@dannyrb: any updates regarding a merge?

toj11001 avatar Nov 22 '21 08:11 toj11001

Closing and reOpening for netlify checks

sedghi avatar Dec 23 '21 22:12 sedghi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 12:07 stale[bot]

@sedghi would you be able to merge this PR please?

toj11001 avatar Feb 03 '23 11:02 toj11001

@GitanjaliChhetri @igoroctaviano Could one of you guys please take a look at this?

sedghi avatar Feb 03 '23 13:02 sedghi

base has changed, read more here https://github.com/OHIF/Viewers/issues/3477

sedghi avatar Jun 19 '23 13:06 sedghi

we updated all the recipes recently, please see if the issue still persists

sedghi avatar Oct 03 '23 15:10 sedghi