DatabaseConnector icon indicating copy to clipboard operation
DatabaseConnector copied to clipboard

Download drivers `method` argument

Open anthonysena opened this issue 2 years ago • 0 comments

The function for downloading drivers downloadJdbcDrivers has an argument method which is then passed to utils::download.file per the documentation here:

https://github.com/OHDSI/DatabaseConnector/blob/6bdece864cfa9a5c9ea9b6d5473df4d2f8a30335/R/Drivers.R#L36

Looking at the documentation for utils::download.file, the method argument will assume a default value of auto but it can be overridden using options(download.file.method = "auto").

So I'd propose we remove the method argument since it prevents users from controlling the behavior of utils::download.file using options and instead we can just note this in the description of the function or link to the utils documentaiton.

anthonysena avatar Oct 16 '22 18:10 anthonysena