DataQualityDashboard icon indicating copy to clipboard operation
DataQualityDashboard copied to clipboard

notification about non-preferred units

Open vojtechhuser opened this issue 5 years ago • 3 comments

KB-driven templated rules are great ! I tried to have those in Achilles and I was always referred to the perfect re-design in phase 2 of Achilles. DQD just did it. I love it.

In ThemisConcept study, we defined data driven preferred units.

How DQD can implement this logic?

Perhaps a column that indicates a unit as non-preferred?

image

vojtechhuser avatar Sep 09 '19 16:09 vojtechhuser

The prefered units per lab test are here: https://github.com/vojtechhuser/ThemisConcepts/blob/master/extras/results2019/S7-preferred_units-ABC.csv

vojtechhuser avatar Sep 09 '19 16:09 vojtechhuser

change to CDM convention is here (always in review status despite it is 60+ days) (sigh....) https://github.com/OHDSI/Themis/issues/4

vojtechhuser avatar Sep 09 '19 16:09 vojtechhuser

@vojtechhuser I love this idea, perhaps we can add another column in the concept level checks for this? We would of course need to add an SQL statement to evaluate it and add it to the R function.

clairblacketer avatar Sep 20 '19 15:09 clairblacketer

I am closing this as we implemented new measurement checks looking for plausible units and we removed the plausible value checks.

clairblacketer avatar Oct 12 '22 16:10 clairblacketer