CommonDataModel icon indicating copy to clipboard operation
CommonDataModel copied to clipboard

Can't find the vocabulary loading scripts

Open rjiang9 opened this issue 3 years ago • 6 comments
trafficstars

Hi friends,

I downloaded the vocabulary 5.0 from athena.ohdsi.org. In the email with the download link, it says:

The control files can be found [here](https://github.com/OHDSI/CommonDataModel). They are provided in the folders Oracle/, PostgreSQL/ and SQL Server/ for the respective SQL dialect. The loading scripts are inside the subfolder VocabImport/.

I am using Postgres and cdm5.4, but I did not see the subfolder of VocabImport in the Postgres folder:

https://github.com/OHDSI/CommonDataModel/tree/master/inst/ddl/5.4/postgresql

Am I going to the wrong place for it?

Thank you for help. Ray

rjiang9 avatar Mar 30 '22 19:03 rjiang9

The script can be found on one of the historical branches. https://github.com/OHDSI/CommonDataModel/blob/v5-historical/PostgreSQL/VocabImport/OMOP%20CDM%20vocabulary%20load%20-%20PostgreSQL.sql

@clairblacketer is this script part of the current version of the CommonDataModel package?

ablack3 avatar Mar 31 '22 17:03 ablack3

We need to upgrade the information for 5.4.

cgreich avatar Mar 31 '22 18:03 cgreich

@cgreich Got it, Thank you! What need to be upgrade for 5.4 by the way?

rjiang9 avatar Mar 31 '22 18:03 rjiang9

@ablack3 thank you for the info Adam!

rjiang9 avatar Mar 31 '22 18:03 rjiang9

We made a decision to not include this with the CDM package as it does not translate well through SqlRender and we felt it made more sense being owned by the vocabulary team. We can bring this up at the next meeting.

@rjiang9 I would also suggest using the ETL-Synthea LoadVocabFromCsv function, or at least the underlying SQL. This is the one I frequently use and it works well in Postgres.

@ablack3 it is not a function in the current package but we can look at adding it. @rjiang9 there is nothing specific for v5.4 that needs to be updated, we just need to add a function to do this.

clairblacketer avatar Mar 31 '22 19:03 clairblacketer

Thank you for the info @clairblacketer ! I appreciate it. If the email template for the vocabulary down is updated with your 'ETL-Synthea LoadVocabFromCsv function, it will not only remove the confusion but also have a brighter solution. This is no such subfolder with name 'VocabImport' any more.

rjiang9 avatar Mar 31 '22 21:03 rjiang9