CohortDiagnostics icon indicating copy to clipboard operation
CohortDiagnostics copied to clipboard

Published 20 hours ago • verified publisher icon OHDSI

Compare Chararacterization: StDiff enhancements

Open pbr6cornell opened this issue 2 years ago • 2 comments

Two items on standardized difference:

  1. All StDiff values should be listed with 2 decimals. currently we only show 1 decimal point: image

  2. If target or comparator has 0%, but the other cohort has a value >0%, we should be able to compute StDiff. Currently, StDiff is NULL in these cases: (need to coalesce the null cohort to have mean = 0, stdev = 0, then the standard StDiff formula will be fine).

image

pbr6cornell avatar Sep 25 '22 00:09 pbr6cornell

Note, I think this may be specifically influenced by the 'Min Covariate Mean' user input parameter. It could be there is non-zero values that just fall below the threshold.

pbr6cornell avatar Sep 25 '22 00:09 pbr6cornell

The calculation has been fixed as per screenshot below: Screenshot 2022-09-26 at 10 23 54 AM

however, I'm keeping this issue open as currently the operation is slow as legacy code pulls down data the target and comparator separately - Instead it would be significantly more performant to pull it down for both doing the standard diff calculation in SQL.

azimov avatar Sep 26 '22 17:09 azimov