Atlas icon indicating copy to clipboard operation
Atlas copied to clipboard

Use concept sets for attributes

Open vojtechhuser opened this issue 4 years ago • 5 comments

Expected behavior

attributes don't have to be enumerated but can be managed as a concept set e.g., diagnosis type or unit of measurement

Actual behavior

I have to enumerate

To create a new initial event or criterion, I have concept sets at my disposal. Huge advantage.

For attributes, I don't have that luxury. I must have local files with concept sets that I paste and import. Not good for user.

Steps to reproduce behavior

2021-01-08 11_20_00-ATLAS Cohort Definitions (unsaved)

vojtechhuser avatar Jan 08 '21 16:01 vojtechhuser

How does a hierarchy of units make sense for use of concept sets? Would you ever say something like "I'm looking for 5 with a unit of any kind of gram (kg, mg, g)."?

chrisknoll avatar Jan 16 '21 04:01 chrisknoll

I also request this feature to be added.

My use case: I have created a concept set from the Meas value domain for Measurement.value_as_concept_id. This concept set consists of > 200 values. I would like to use the 'import' button to import the concept set as I do for other definitions.

MelaniePhilofsky avatar May 13 '21 16:05 MelaniePhilofsky

That's a good use-case, and I think it makes sense for allowing a user to specify concept sets for value_as_concept due to the hierarchical nature of the data. Units? Doesn't make sense in that case. So, for starters, I think I can extend the Measurement criteria to include a 'value as conceptset' such that you have the choice to specify the concepts as a list (existing functionality) or concept sets (new functionality).

We're having discussions about where else to make this option available, and it is wavering between 'make every concept selector into a concept set' vs. 'the UI needs a way to define simple concept lists that can be referenced in these areas'. We're leaning towards the former because concept sets are more 'sharable' but the issue is that using the hierarchical nature of concept sets doesn't make sense in all places (units, gender, status, etc). But I think we can approach the problem to where it makes the most sense to make the change, and work outwards from there.

chrisknoll avatar May 13 '21 18:05 chrisknoll

Linking this issue to #2631 as they are related to the same functionality.

anthonysena avatar May 03 '22 21:05 anthonysena

replace all concept selectors with conceptsets.

pbr6cornell avatar Apr 18 '23 13:04 pbr6cornell