Value as concept for Measurement should not be a concept picker, but conceptset

[cgreich]

[Alexdavv]

The same for Observation, please.

BTW, @cgreich, @pbr6cornell, I've looked through all the attributes. Don't we need concept-set functionality for the following attributes (when working inside the initial event, restriction criteria or inclusion criteria):

• Visit / Visit Occurrence what must be the same thing (is it even used in such a way? If yes, hierarchy will not gonna work here now)
• Provider Specialty (hierarchy will not gonna work here now)
• Race
• Event Type (even after type becomes Domain-unspecific)
• Place of Service (is it still supported?)
• Anatomic site in Specimen

And we should be ok with import button working for the rest:

• Gender
• Ethnicity
• Unit
• Route
• Value Operator
• Observation Qualifier
• Procedure Modifier
• Disease status in Specimen

And finally, additional filters (by vocabulary_id and standard_concept) might be really helpful in the picker window:

[anthonysena]

Tagging @chrisknoll here for input but at first glance the challenge I see is the JSON cohort expression is expecting a list of concept IDs vs a concept set reference. Changing this paradigm would be a breaking change and would better be reserved for discussion with the next major release.

As for the concept picker window this again may be better for the 3.0 version.

[chrisknoll]

Agreed, this is a breaking change if we re-define what those fields are, but we can introduce new criteria params that are stored as a different field and are understood to be concept set instead of list of concepts.

[anthonysena]

Also noting that @clairblacketer raised a similar point in #2140 as it relates to using the visit hierarchy as part of defining visit events.

[pbr6cornell]

related to other issues. if we replace all 'concept pickers' with conceptsets we will close mutiple issues.

[Alexdavv]

related to other issues. if we replace all 'concept pickers' with conceptsets we will close mutiple issues.

Is it a good solution for the things where the concept-set would always include 1-2 concepts?

And we should be ok with import button working for the rest:

• Gender
• Ethnicity
• Unit
• Route
• Value Operator
• Observation Qualifier
• Procedure Modifier
• Disease status in Specimen