Athena icon indicating copy to clipboard operation
Athena copied to clipboard

Download Older vocabulary package not working in History

Open PRijnbeek opened this issue 4 years ago • 8 comments

When i try to download a previous bundle it start building it again but when you then download you do not get that bundle but the latest.

image

I do get an email that says:

Link for downloading the Standardized Vocabularies

Vocabularies release version: v5.0 07-AUG-20

But the vocabulary.csv i get is from 28-AUG-20

PRijnbeek avatar Aug 29 '20 12:08 PRijnbeek

Hi Peter, Please note, we don't keep the historical files, so it's impossible to get the vocabulary from the previous version. It creates the bundle based on the vocabulary_ids, current vocabulary version (28-AUG-20), but sends the email with the version at the moment you requested it the first time. Has to be fixed. I'll discuss with the team.

On Sat, Aug 29, 2020 at 3:22 PM Peter Rijnbeek [email protected] wrote:

When i try to download a previous bundle it start building it again but when you then download you do not get that bundle but the latest.

[image: image] https://user-images.githubusercontent.com/7252105/91636686-e28dcf00-ea02-11ea-8f11-aae4a933aef3.png

I do get an email that say:

Link for downloading the Standardized Vocabularies

Vocabularies release version: v5.0 07-AUG-20

But the vocabulary.csv i get is from 28-AUG-20

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OHDSI/Athena/issues/196, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBMA77Y2PK45E7KRUV52DLSDDXH3ANCNFSM4QO65EHQ .

dimshitc avatar Aug 29 '20 12:08 dimshitc

Okay so what you mean with Restore is actually not a Restore but an Update of the vocabs that have been selected in that bundle?

That is indeed very confusing to the user. The interface suggests you can restore the bundle you made earlier: image

What does Archived than mean?

So is the workflow that you create a bundle = select the vocabs you need and then every time you need an update you "Restore"?

PRijnbeek avatar Aug 29 '20 12:08 PRijnbeek

But why does it say V5.0 07-AUG-20 in that second one still after I clicked Restore??

PRijnbeek avatar Aug 29 '20 12:08 PRijnbeek

Yeah, indeed very confusing. Especially that it mistakenly puts the old date in the email. I'll talk to the team on Monday in order to rename this.

dimshitc avatar Aug 29 '20 12:08 dimshitc

Technically there is no way to restore older version, this label indicates version which was packed into the zip first time only. We can delete it from this screen and keep only actual in the email.

acumarav avatar Aug 31 '20 09:08 acumarav

I understand this is unfortunately the case.

The term restore is really confusing in the interface see above. You are not restoring that package.

A manual for Athena would help for new users.

PRijnbeek avatar Aug 31 '20 09:08 PRijnbeek

Athena is set to keeps archive files for 3 days. Restore mean - recreate package. IMHO the optimal behavior will be to allow "Restore" only if the vocabulary version match. If it has changed then "Delete Bundle" should be the only option.

acumarav avatar Mar 10 '21 08:03 acumarav

what is useful is if you can store the list of vocabularies you use and would be able the get an updated bundle (so it remembers my settings)

This is how we now "miss-use" the restore (which is not the right term).

Not sure what you mean with "if the vocabulary version match". this happens almost never does since we have very frequent vocabulary updates.

PRijnbeek avatar Mar 10 '21 08:03 PRijnbeek