ogre icon indicating copy to clipboard operation
ogre copied to clipboard

Should MeshMagick be integrated into the OGRE repo?

Open sercero opened this issue 1 year ago • 7 comments

I was wondering why MeshMagick sits apart from the rest of the OGRE tools.

sercero avatar Apr 28 '24 18:04 sercero

it was started outside of Ogre, thats why it never was part of the Ogre tools. However, since I switched Ogre to the monotree approach, it could be merged.

That being said, there doesn't seem to be a great deal of interest or usage of the tool, and it would need to be updated to align with Ogre's current build, test, and documentation frameworks.

paroj avatar Apr 28 '24 20:04 paroj

I think it would be useful to have amongst the other tools that come with OGRE, perhaps people are not aware of the tool because of that.

Anyway I wanted to know if you were open to integrating it....

sercero avatar Apr 28 '24 22:04 sercero

the problem with integrating meshmagick is that it is also a library as shown by the doxygen file in the repo. So we would need to split it into a component and a tool which complicates things.

Also one should clean up the code before merging:

  • replace tootle
  • remove the ogre-next ifdefs

for now I have added it to the tools page on the website: https://www.ogre3d.org/download/tools

paroj avatar May 03 '24 22:05 paroj

the problem with integrating meshmagick is that it is also a library as shown by the doxygen file in the repo. So we would need to split it into a component and a tool which complicates things.

Also one should clean up the code before merging:

  • replace tootle
  • remove the ogre-next ifdefs

for now I have added it to the tools page on the website: https://www.ogre3d.org/download/tools

Is tootle obsolete?

If there are ogre-next ifdefs then perhaps it is an argument against integrating it into this repo...

sercero avatar May 04 '24 00:05 sercero

Is tootle obsolete?

yes, see https://github.com/OGRECave/meshmagick/issues/7

If there are ogre-next ifdefs then perhaps it is an argument against integrating it into this repo...

it is actually a separate branch. forgot the details.

looking at the commits, it seems that tootle is the most used feature. For that we could just improve -optvtxcache in MeshUpgrader by using meshoptimizer directly.

paroj avatar May 04 '24 12:05 paroj

Is tootle obsolete?

yes, see OGRECave/meshmagick#7

OK, tootle is discontinued by AMD but is it not useful anymore?

If there are ogre-next ifdefs then perhaps it is an argument against integrating it into this repo...

it is actually a separate branch. forgot the details.

looking at the commits, it seems that tootle is the most used feature. For that we could just improve -optvtxcache in MeshUpgrader by using meshoptimizer directly.

Is it a proper replacement for tootle? I'm asking from ignorance.

Thanks

sercero avatar May 04 '24 12:05 sercero

Is it a proper replacement for tootle? I'm asking from ignorance.

I have no idea how what the ranking of current -optvtxcache vs tootle vs meshoptimizer is. Someone would need to benchmark I guess..

paroj avatar May 04 '24 13:05 paroj