ogre-next icon indicating copy to clipboard operation
ogre-next copied to clipboard

Tests suite wholly disabled?

Open apteryks opened this issue 1 year ago • 3 comments

Hi,

Looking at https://github.com/OGRECave/ogre-next/blob/12eef284d51f3e727aef2840ad4e4bf5c1d981a7/CMakeLists.txt#L724, I see the test suite is disabled (0 is equivalent to FALSE in CMake expressions, right?).

Should it still be disabled? The former ogre (not next) appears to have a working test suite.

apteryks avatar Oct 29 '24 06:10 apteryks

Hi!

The old test suit was never ported to OgreNext so it was disabled. We have newer tests that do work.

We do not have formal coverage reports if that's what you're asking. It was in the roadmap for 3.0 but it was postponed.

darksylinc avatar Oct 29 '24 14:10 darksylinc

Oh! Would it be possible to reinstate ENABLE_TESTING() (see: https://github.com/OGRECave/ogre-next/blob/12eef284d51f3e727aef2840ad4e4bf5c1d981a7/CMakeLists.txt#L726) if there are new tests? That takes care of adding a 'test' target, which makes it easy to run the test suite.

apteryks avatar Oct 30 '24 02:10 apteryks

I checked a bit and I don't see the use of CTest's add_test macro for theses tests, so I guess I'd need to run each binary manually; the github CI here doesn't seem to be running these tests so it's hard to tell.

apteryks avatar Dec 18 '24 12:12 apteryks