Diffuse/specular parameters are mixed incorrectly. Or not?

[Th3V1kt0r]

Diffuse/specular parameters are mixed incorrectly. Or not? In any case, there are visible differences. Left picture as it is. Right picture with my changes.

I have only set ambient light in the scene: sceneManager->setAmbientLight( Ogre::ColourValue( 1.0f, 0.0f, 0.0f ), Ogre::ColourValue( 1.0f, 1.0f, 1.0f ), Ogre::Vector3::UNIT_Y);

[darksylinc]

WHAT THE...?!?!

Yes this a bug. And it's been there since like forever???

I know that the ambient hemisphere lighting is just a hack, but still...

I'll have to evaluate how much impact it makes on the scenes because it seems to be significant enough to be mentioned by the documentation.

Release 3.0 will also be making a change to PBR so it'd be great if we can include it with that release.

[darksylinc]

I've finally had some time to look into this.

Due to how significant this change can be, I added the ability to switch between the old and new method.

Thank you for your PR! It's been merged by hand.

[cryham]

Holy f*ing cow :eyes: I have to check if that explains messed up light on my terrain, road etc.