ogre-next icon indicating copy to clipboard operation
ogre-next copied to clipboard

Published 20 hours ago • verified publisher icon OGRECave

Choose SIMD implementation at cmake time

Open crjc opened this issue 4 years ago • 2 comments

A less drastic version of #157 (this doesn't delete proxy files or change folder structure). A motivating factor behind deleting the proxy files was to prevent multiple files having the same name so that ninja/vcpkg/Xcode would not complain, although this doesn't seem to be an issue anymore with the changes I've made.

This PR merges both the OGRE_SIMD_SSE2 and OGRE_SIMD_NEON flags into a single flag OGRE_SIMD, and CMake is now responsible for picking SSE2, NEON or C.

crjc avatar Dec 11 '20 23:12 crjc

Ah! I forgot that was the problem.

It IS acceptable to rename each implementation-specific file (e.g. append a suffix) so that naming becomes unique.

AllianceDarkSylinc avatar Dec 11 '20 23:12 AllianceDarkSylinc

Not completely related, but would it be ok to rename: OgreMain/include/Animation/OgreTagPoint.h to OgreMain/include/Animation/OgreTagPoint2.h

This seems to be the convention used for other files and would resolve conflicting names with the file: OgreMain/include/OgreTagPoint.h

crjc avatar Dec 12 '20 01:12 crjc