Kevin Hellemun

Results 160 comments of Kevin Hellemun

found it :) ``` "attachment": { "id": 3647492, "description": "", "content_type": "image\/jpeg" } ``` is an object but, this is how it's defined: https://github.com/bunq/sdk_php/blob/f369d3b931ea833e06d40bda85620506a31568a2/src/Model/Generated/Endpoint/NoteAttachmentMasterCardAction.php#L72-L77 So please remove the `[]` from...

so @kojoru this can either be an view definition mistake or the actual response is wrong :)

@holtkamp thanks for this suggestion. Ill tackle this in 0.13.0.

@holtkamp What do you mean with `implemented something which currently "does the job"`. The way the ApiClient Is build it would not be possible to remake a call after a...

No not really 😭. Im packed with internal projects and therefore didn't get time to work on github projects. PR's are highly appreciated tho. Next week ill be on holiday...

> While Bunq is pushing a lot of "crazy awesome nice amazing" new features in well marketed "product updates", it seems some basic functionality like request throttling of the official...

So i took a look at this, and it seems that the current way the request and response handlers are created: https://github.com/bunq/sdk_php/tree/e9511e1c158a2c8d768d167bc05a66d7d88ea5d5/src/Http/Handler The response handlers do not have the request...

I've created a PR. the only thing that we need to figure out now is how we're going to test an actual request. I hate the fact that the SDK...

just to clarify my retry approach, as this SDK is build based on static methods and singletons. It makes no sense to keep a global mapping to throttle the requests...

> Well, in my case the client gets initialized on a daily basis to perform a batch of operations. So this client is "long living". Thats not what i meant,...