tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

cfl error in merging_glaciers notebook

Open pat-schmitt opened this issue 2 years ago • 7 comments

On the website a cfl error occurs in the merging_glaciers notebook. But I could not reproduce the error locally, not sure how to proceed.

pat-schmitt avatar Mar 11 '22 11:03 pat-schmitt

Can you try to set cfl_number to 0.01?

fmaussion avatar Mar 11 '22 12:03 fmaussion

I also could not reproduce with cfl_number 0.01 locally. I also created an env with the same oggm version as is used on mybinder and was not able to reproduce the error. Maybe there is something going on in the docker image. I can try to run the notebook from the image to reproduce the error.

pat-schmitt avatar Mar 14 '22 13:03 pat-schmitt

ah and before this I test also with python 3.10

pat-schmitt avatar Mar 14 '22 13:03 pat-schmitt

You can also try to push cfl to 0.01 in a PR and trigger a build online, but the problem is that we won't know what the problem is.

Maybe something in the output changed again :cry:

cc @TimoRoth

fmaussion avatar Mar 14 '22 13:03 fmaussion

ok python 3.10 was not the problem. What do you mean with pushing cfl to 0.01? I tested on my binder with cfl 0.01 and the tutorial still fails.

pat-schmitt avatar Mar 14 '22 15:03 pat-schmitt

Ah ok ok - great thanks.

fmaussion avatar Mar 14 '22 15:03 fmaussion

Another solution would be to simplify this example or remove it, but that's some work or a bit sad,

fmaussion avatar Mar 15 '22 14:03 fmaussion