oc-mall-plugin icon indicating copy to clipboard operation
oc-mall-plugin copied to clipboard

Missing data for Invoice order partial

Open dathwa opened this issue 9 months ago • 1 comments

Hello. Mall 3.2.1 Using the partial from mall theme taxes.htm Prevoiusly, entry.tax.name, entry.tax.percentage and entry.total_formatted were all available. Now i am missing entry.tax.name (as well as a few other unused vars). Is this normal? Thank-you.

Examples Custom Method (before)

"taxes" => array:1 [▼
    0 => array:5 [▼
      "tax" => array:8 [▼
        "id" => 1
        "name" => "UK VAT"
        "percentage" => "20.00"
        "created_at" => "2020-01-29T14:26:02.000000Z"
        "updated_at" => "2020-02-26T15:12:18.000000Z"
        "is_default" => true
        "pivot" => array:2 [▶]
        "countries" => []
      ]
      "amount" => 4167
      "total" => 833
      "amount_formatted" => "£ 41.67"
      "total_formatted" => "£ 8.33"
    ]
Stripe (after)
 "taxes" => array:1 [▼
    0 => array:5 [▼
      "tax" => array:1 [▼
        "percentage" => "20.00"
      ]
      "amount" => 833
      "total" => 167
      "amount_formatted" => "£ 8.33"
      "total_formatted" => "£ 1.67"
    ]
  ]

dathwa avatar May 02 '24 09:05 dathwa

Hello,

Unfortunately, the detailed data about the used tax is not passed to the PriceBag construct, which is used for the TotalsCalculator class. I'm currently improving the PriceBag handling anyway and will pass the missing data to fix this issue.

Sincerely,
Sam.

SamBrishes avatar Jun 03 '24 10:06 SamBrishes