oc-bootstrapper icon indicating copy to clipboard operation
oc-bootstrapper copied to clipboard

Error when updating, plugins extends missing ones

Open damsfx opened this issue 4 years ago • 3 comments

Hi all...

Funny behavior today, little brief:

  • plugin A (free plugin of the marketstore)
  • plugin B (site/project plugin, extend plugin A)

During the update the plugins are deleted to be reinstalled, but the plugin that extends one of them creates a bug because it uses classes (use \Acme\plugin\...) that are no longer present!

My only possible solution is to temporarily disable the project plugins that extend the others during the commit time and then reactivate them.

Have you ever encountered this kind of situation before?

damsfx avatar Oct 24 '19 13:10 damsfx

If plugin A comes from the marketplace, it should not be removed during the install process. Custom plugins are only removed, if they are marked as updateable (begins with ^).

Are you running october install or october update?

Also, the bootstrapper should not care about any plugin dependencies since it's running on its own. Can you share the effective error message you see?

tobias-kuendig avatar Oct 24 '19 14:10 tobias-kuendig

If plugin A comes from the marketplace, it should not be removed during the install process. Custom plugins are only removed, if they are marked as updateable (begins with ^).

Ho ... you are right!
I have two plugins that extend A, the first as generic as possible and the second is typicaly for my client.

  • plugin A (from market)
  • (^)plugin B (add functionality to A)
  • plugin C (extends two first)

Are you running october install or october update?

In this case ... both failed.

Also, the bootstrapper should not care about any plugin dependencies since it's running on its own. Can you share the effective error message you see?

october install

Downloading latest October CMS...
-> October is already installed. Use --force to reinstall.
Installing composer dependencies...
Setting up config files...
-> Configuration already set up. Use --force to regenerate.
Migrating database...
Installing Theme...
-> Theme is already installed. Skipping.
Setting Project ID...  

[RuntimeException]
Error running "php artisan october:util set project --projectId=xxxxxxxxxxxxxxxxxx" command: 

[Symfony\Component\Debug\Exception\FatalThrowableError]
Class 'VojtaSvoboda\Reservations\Models\Settings' not found

october update

Installing new plugins
Removing private plugins
Cleared private plugins
Running artisan october:update
Reinstalling plugins:
- Indikator.Backend

[RuntimeException]
Error while installing plugin Indikator.Backend via artisan: 

Error running "php artisan plugin:install Indikator.Backend" command:

[Symfony\Component\Debug\Exception\FatalThrowableError]  
Class 'VojtaSvoboda\Reservations\Models\Settings' not found

damsfx avatar Oct 24 '19 17:10 damsfx

Have found a solution ...
No more plugins in the site (white-listed in the gitignore) but have all plugins in remote repos.
With keepRepo option set to true; just have to push plugins updates prior to push site.

damsfx avatar Mar 23 '21 01:03 damsfx