Add support for "Any" and Predicates method call expressions

[joecarl]

Issues

This pull request fixes #1996.

Description

This PR implmements Any method support. (Internally it fakes a Count request and transforms numeric response into boolean value). It also adds support for the following sequence methods: AnyPredicate, CountPredicate, LongCountPredicate, FirstPredicate, FirstOrDefaultPredicate, SinglePredicate, SingleOrDefaultPredicate

E.g.:

var ctx = new DataServiceContext(new Uri(...));
var dataSet = ctx.CreateQuery<Customer>("Customers");
// The following lines will work fine without throwing Exception now:
bool exists1 = dataSet.Any();
bool exists2 = dataSet.Any(c => c.Name.Contains("ab"));
int count1 = dataSet.Count(c => c.Name.Contains("ab"));
long count2 = dataSet.LongCount(c => c.Name.Contains("ab"));
Customer c1 =  dataSet.First(c => c.Name != "John");
Customer c2 =  dataSet.FirstOrDefault(c => c.Name == "John");
Customer c3 =  dataSet.Single(c => c.Id == "234111");
Customer c4 =  dataSet.SingleOrDefault(c => c.Id == "234111");

Checklist (Uncheck if it is not completed)

• [x] Test cases added
• [x] Build and test with one-click build and test script passed

[pull-request-quantifier-deprecated[bot]]

This PR has 13 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Small
Size       : +13 -0
Percentile : 5.2%

Total files changed: 1

Change summary by file extension:
.cs : +13 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

[pull-request-quantifier-deprecated[bot]]

This PR has 48 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Small
Size       : +47 -1
Percentile : 19.2%

Total files changed: 1

Change summary by file extension:
.cs : +47 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

[joecarl]

Should I add tests for this? If so, is there any existing file where I could add the tests or should I create a new one?

[nyok1912]

Hi, is there any chance I can download a version including this feature? I am migrating a project from EF to OData and this would save me refactoring hundreds of files. Thanks!

[xuzhg]

Should I add tests for this? If so, is there any existing file where I could add the tests or should I create a new one?

You can find the test file in the Microsoft.OData.Client.Tests project and feel free create a new file if no file existed.

[xuzhg]

Hi, is there any chance I can download a version including this feature? I am migrating a project from EF to OData and this would save me refactoring hundreds of files. Thanks!

Sorry, since this PR is not merged, and we don't have office version released. If the nightly package is ok for you, we can trigger a nightly package for you to try.