odata.net
odata.net copied to clipboard
Fix compilation on Linux
Issues
This pull request fixes #2406.
Description
Renaming the PublicApi directory to PublicAPI fixed compilation on Linux devices. This influences CI/CD pipelines and developers on Linux machines in general.
Checklist (Uncheck if it is not completed)
- [ ] Test cases added
- [ ] Build and test with one-click build and test script passed
This PR has 0 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!
Quantification details
Label : No Changes
Size : +0 -0
Percentile : 0%
Total files changed: 0
Change summary by file extension:
Change counts above are quantified counts, based on the PullRequestQuantifier customizations.
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean:
- Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer iterations.
- Similarity in low PR complexity drives similar review times.
- Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
- Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
- Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.
What can I do to optimize my changes
- Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the
Excludedsection from yourprquantifier.yamlcontext profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your
prquantifier.yamlcontext profile. - Only use the labels that matter to you, see context specification to customize your
prquantifier.yamlcontext profile.
- Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
- Your PR could be split in smaller, self-contained PRs instead
- Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).
- For PRs that fall outside of the desired spectrum, review the details and check if:
How to interpret the change counts in git diff output
- One line was added:
+1 -0 - One line was deleted:
+0 -1 - One line was modified:
+1 -1(git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
The build pipeline fails due to the following:

It seems unrelated to the fix. It could be a flaky test. But there seems to be an issue re-running the pipeline. I will try again later.
@AntiGuideAkquinet could you try to re-create this PR from a different branch? I've not been able to re-run the build pipeline on this PR.
Or make add a new commit and see whether it triggers the pipeline.
I have created a new duplicate PR (https://github.com/OData/odata.net/pull/2549) and rebased changes from master and now the pipeline is running. It seems to have triggered the pipeline for this PR as well.
I merged the other PR (https://github.com/OData/odata.net/pull/2549). Closing this one.