odata.net icon indicating copy to clipboard operation
odata.net copied to clipboard

incorrect case for PublicAPI folder

Open dweeden opened this issue 3 years ago • 2 comments
trafficstars

The last three letters of the path odata.net/src/Microsoft.OData.Edm/PublicApi should be upper case so it compiles on Linux without generating a bunch of RS0016 errors

Assemblies affected

Current version of Microsoft.OData.Edm

Reproduce steps

Pull source onto a Linux machine and try to compile Microsoft.OData.Edm project

Expected result

It would compile

Actual result

It doesn't compile and yields a whole slew of RS0016 errors as it can't find the shipped and unshipped API files

Additional detail

dweeden avatar May 06 '22 22:05 dweeden

Renaming it to PublicAPI fixes the problem for me locally

dweeden avatar May 06 '22 23:05 dweeden

@corranrogue9 ~~It seems to me like changing the Microsoft.OData.Edm.csproj like this~~

// DELETE
<AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Shipped.txt" />
<AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Unshipped.txt" />
// INSERT
<AdditionalFiles Include="PublicApi/$(TargetFramework)/PublicAPI.Shipped.txt" />
<AdditionalFiles Include="PublicApi/$(TargetFramework)/PublicAPI.Unshipped.txt" />

~~would solve the issue.~~ Due to the dependency on VS2019 Enterprise in the build scripts I can't verify this tough. This issue seems like it would have a lot of impact to users building in CI pipelines or on Linux host machines.

EDIT: Renaming the directory was the right call. The above did not work in my tests.

AntiGuideAkquinet avatar Sep 27 '22 11:09 AntiGuideAkquinet