odata.net icon indicating copy to clipboard operation
odata.net copied to clipboard

Remove DataServiceContext.KeyComparisonGeneratesFilterQuery in the next breaking change release.

Open KenitoInc opened this issue 3 years ago • 2 comments

Remove DataServiceContext.KeyComparisonGeneratesFilterQuery in the next breaking change release. This was added so as not to break existing clients.

https://github.com/OData/odata.net/blob/59cc9b6526cc3f43b638c2b15dc9060000c86579/src/Microsoft.OData.Client/DataServiceContext.cs#L684-L691

Assemblies affected

Which assemblies and versions are known to be affected e.g. OData .Net lib 7.x

Reproduce steps

The simplest set of steps to reproduce the issue. If possible, reference a commit that demonstrates the issue.

Expected result

What would happen if there wasn't a bug.

Actual result

What is actually happening.

Additional detail

Optional, details of the root cause if known. Delete this section if you have no additional details to add.

KenitoInc avatar Sep 30 '21 09:09 KenitoInc

~~#2379 might supersede this now~~

EDIT: this is not accurate

corranrogue9 avatar Apr 27 '22 15:04 corranrogue9

This was added to do a more efficient key lookup when a filter on a key is specified. Are there other ways in OData client that a customer can easily do a key lookup (something like a "getbykey" method)?

corranrogue9 avatar May 09 '22 15:05 corranrogue9