AspNetCoreOData icon indicating copy to clipboard operation
AspNetCoreOData copied to clipboard

fixes #580

Open mirgil opened this issue 2 years ago • 5 comments

mirgil avatar Jul 02 '23 11:07 mirgil

@mirgil please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

mirgil avatar Jul 02 '23 11:07 mirgil

I believe the protocol expects these to be lower camel case. If so, changing this would be non-compliant.

Which protocol? Serialization should be done according to the JsonSerializerOptions.PropertyNamingPolicy. If no policy is defined, the original property (name and case) should be used.

mirgil avatar Aug 06 '23 14:08 mirgil

I believe the protocol expects these to be lower camel case. If so, changing this would be non-compliant.

@mikepizzo I might be wrong but I think that the PageResultValueConverter is applicable in non-EDM scenarios - I don't think the items, nextpagelink and count property names used currently have anything to do with OData standard. @xuzhg can correct me if I'm wrong. Be that as it may, this PR has no tests to validate the changes.

Thank you @mirgil for you contribution. Could you please add tests to validate the changes?

gathogojr avatar Sep 25 '23 06:09 gathogojr

Please provide a description of the problem and how this fixes it in the pr description.

wachugamaina avatar Mar 08 '24 11:03 wachugamaina

Could we have some tests for the new functionality ?

wachugamaina avatar Mar 08 '24 11:03 wachugamaina