superbol-studio-oss icon indicating copy to clipboard operation
superbol-studio-oss copied to clipboard

Make SuperBOL configs CamelCase in VSCode extension

Open engboris opened this issue 7 months ago • 2 comments

In src/vscode/superbol-vscode-platform/settings.ts there is an occurrence of display-variable-attributes , gdb-path and libcob-path:

    public get displayVariableAttributes(): boolean {
        return this.debugSettings.get<boolean>("display-variable-attributes");
    }

    public get gdbpath(): string {
        return this.debugSettings.get<string>("gdb-path");
    }

    public get libcobpath(): string {
        return this.debugSettings.get<string>("libcob-path");
    }

I don't know if any of these have to be modified.

Closes #407

engboris avatar May 23 '25 13:05 engboris

Tests have been done for:

  • source-format (by changing the workspace config and see effect on source code);
  • cobc (by looking at the path used by the F5 command);
  • lsp-path and superbol.toml (created with the SuperBOL: Write Project Configuration command) which outputs what is expected.

I probably missed something and I'm not sure how to properly test display-variable-attributes, libcob-path and gdb-path.

engboris avatar May 23 '25 14:05 engboris

You can at least test them when building it locally (needs to be pushed to the sub-repo later) and running it.

gdb-path is the debugger binary that is started (just set to an invalid entry, start, get an error, set to full path, start, have debugging, unset the path [so it is searched for in PATH], start debugging) display-variable-attributes -> check (was it with hover?) how the variables are shown in the debugger view when this is (not) active.

GitMensch avatar May 23 '25 17:05 GitMensch

Also: https://github.com/OCamlPro/superbol-vscode-debug/pull/12 needs to be merged first, and the submodule update be included in the current PR.

nberth avatar May 26 '25 09:05 nberth