gnucobol icon indicating copy to clipboard operation
gnucobol copied to clipboard

Add optional index check in 3.x

Open ddeclerck opened this issue 1 year ago • 7 comments

This PR attemps to backport SVN commit 4953 4954 & 5358 to 3.x.

ddeclerck avatar Oct 09 '24 10:10 ddeclerck

Actually I'm not very confident I could do that quickly enough. I'd rather delegate this so I could focus on the GC3/GC4 merge - the clock's ticking and the days allocated to this task are almost depleted.

ddeclerck avatar Oct 10 '24 16:10 ddeclerck

I was surprised you took on that backport. The issue that I've now realized is - if you want to merge the dialect option from GC3 to GC4 then this has to be done in any case :-/

GitMensch avatar Oct 10 '24 16:10 GitMensch

I was surprised you took on that backport. The issue that I've now realized is - if you want to merge the dialect option from GC3 to GC4 then this has to be done in any case :-/

True indeed ; that dialect option is commit 5087 (so this will be a problem in ~50 commits). Though I'm just realizing now that feature was implemented by Nicolas ; I'm gonna ask him for help.

ddeclerck avatar Oct 11 '24 08:10 ddeclerck

MSVC CI should be fixed with updating from upstream (I've worked on that before my vacation).

Apart from that: What is the state of this PR?

GitMensch avatar Oct 21 '24 14:10 GitMensch

Apart from that: What is the state of this PR?

I'd stay "stale" - waiting for someone else to take over. In the meantime I made PR #194 to (temporarily) disable that check in GC4 so that I could continue the merge (as discussed in https://github.com/OCamlPro/gnucobol/pull/147#issuecomment-2405586694).

ddeclerck avatar Oct 21 '24 16:10 ddeclerck

Just stumbled over this, maybe the parser change already handles the issues mentioned in https://sourceforge.net/p/gnucobol/bugs/228/ (or can be extended to that)?

GitMensch avatar Jan 03 '25 17:01 GitMensch

Just stumbled over this, maybe the parser change already handles the issues mentioned in https://sourceforge.net/p/gnucobol/bugs/228/ (or can be extended to that)?

No it does not. Is it only about raising an error/warning in this case (maybe with/without a dialect option)?

nberth avatar Jan 14 '25 13:01 nberth