[FEATURE] Add hardware id in IPDiscover rest API data

[dust63]

Can you add the hardware id of the computer that made the discover on the ip discover api data.

[ [ "192.168.1.2", "AA:BB:CC:AA:BB:C1", "255.255.255.0", "192.168.1.128", "2020-08-26 14:30:15", "device1", TO ADD--> "56", ], [ "192.168.1.3", "AA:BB:CC:AA:BB:C2", "255.255.255.0", "10.128.111.128", "2020-06-25 21:26:31", "device2", TO ADD --> "56", ] ]

[gillesdubois]

Hi,

I just have a question since OCS doesn't link IPDiscover with the computer that performed the scan. What are the advantages to do so ? To be honest I don't see why we should link these two information ?

Regards, Gilles.

[cactux]

One goal would be able to inherit meta-data. For example the use of an asset, or its location, which could then be copied to all assets ipdiscovered by it.

[dust63]

Like @cactux say. You can manage some operation with the data of the agent that discover the ips. For example: Gettings ips of the discover agent to know where the vlan are used to discover the ips.

[gillesdubois]

Hi,

Indeed, can't argue what you are saying. In the mean time, we added the IPDiscover by tag, its not a accurate as having the hardware_id but still you can have more informations on where the data comes from. (of course you need to manage different tags)

I'll discuss this subject with our team and see if we can implement this easily.

Regards, Gilles.

[thfiliol1]

Hi @gillesdubois ,

I worked on this feature :) #270

[dust63]

@gillesdubois can you please integrate this feature on OCS ?

[gillesdubois]

Hi @dust63 ,

Please check my anwser here : https://github.com/OCSInventory-NG/OCSInventory-Server/pull/270

Regards, Gilles.