hdx-ckan icon indicating copy to clipboard operation
hdx-ckan copied to clipboard

Fail gracefully when resource is too large

Open cjhendrix opened this issue 9 years ago • 6 comments

We are currently establishing a (functioning) limit on uploaded file size ( #2935 ) We need to provide feedback to the user when this is exceeded.

cjhendrix avatar Jul 08 '15 13:07 cjhendrix

Related to #2406

reubano avatar Jul 08 '15 19:07 reubano

@cjhendrix is this issue still available?

danmihaila avatar Jul 22 '15 15:07 danmihaila

I haven't tested it, but my upload speed is very slow for testing this. As far as I know, it still needs to be done. Not urgent, since few users will upload files that big.

cjhendrix avatar Jul 23 '15 09:07 cjhendrix

I would suggest to use client side javascript to check the file size. Start the search here: http://stackoverflow.com/questions/7497404/get-file-size-before-uploading and follow jQuery links. This is the most graceful way I could think of AND it avoids partial uploads. Because it would be awful to have a file_size = max_file_size + 10 KB and to fail after uploading almost the whole file.

teodorescuserban avatar Jul 23 '15 09:07 teodorescuserban

@cjhendrix is this still an issue?

danmihaila avatar Sep 08 '15 09:09 danmihaila

As far as I know, yes. We fail on large file sizes (500mb) but we don't give a clear indication to the user of what happened or why.

cjhendrix avatar Sep 08 '15 12:09 cjhendrix