hdx-ckan icon indicating copy to clipboard operation
hdx-ckan copied to clipboard

Published 20 hours ago • verified publisher icon OCHA-DAP

https green lock broke by some [new pages]

Open teodorescuserban opened this issue 9 years ago • 11 comments

https://data.hdx.rwlabs.org/dataset/ebola-treatment-centers/resource/007c38f0-2efe-4f4a-8b47-f7eb5a4d20eb

Error in browser console: Mixed Content: The page at 'https://data.hdx.rwlabs.org/dataset/33b20dce-dae1-48b0-bc71-6b728321711e/resource/007c38f0-2efe-4f4a-8b47-f7eb5a4d20eb/preview' was loaded over HTTPS, but requested an insecure image 'http://data.hdx.rwlabs.org/vendor/leaflet/0.4.4/images/marker-shadow.png'. This content should also be served over HTTPS.

Please track down the anchor link and make it https (or find another way).

Tagging @cjhendrix and @danmihaila to assign / change labels.

teodorescuserban avatar Mar 19 '15 21:03 teodorescuserban

Steps to reproduce:

  1. Access https://data.hdx.rwlabs.org/dataset/ebola-treatment-centers/resource/007c38f0-2efe-4f4a-8b47-f7eb5a4d20eb
  2. Go to the third tab ("Map")
  3. Choose latitude and longitude
  4. Click update.
  5. Check the browser console and the icon near "https" in browser address bar.

teodorescuserban avatar Mar 19 '15 21:03 teodorescuserban

@teodorescuserban is this still an issue?

danmihaila avatar May 13 '15 09:05 danmihaila

Yes. The page requests resources from leaflet site, although we should use the cached ones in nginx (similar to mapbox or openstreetmap).

teodorescuserban avatar May 13 '15 09:05 teodorescuserban

moved to Sprint 56 to be assigned to a dev

danmihaila avatar May 25 '15 08:05 danmihaila

Okay, so this is not a bad link in an anchor tag. This is Leaflet.js incorrectly guessing the root path. I've been able to track this down within the library but I'm still trying to figure out how to fix it with creating a custom build of leaflet :/

mbellotti avatar May 27 '15 15:05 mbellotti

Why use leaflet in the first place?

Mie, 27 mai 2015, 18:59, mbellotti [email protected] a scris:

Okay, so this is not a bad link in an anchor tag. This is Leaflet.js incorrectly guessing the root path. I've been able to track this down within the library but I'm still trying to figure out how to fix it with creating a custom build of leaflet :/

— Reply to this email directly or view it on GitHub https://github.com/OCHA-DAP/hdx-ckan/issues/2473#issuecomment-105974927.

teodorescuserban avatar May 27 '15 16:05 teodorescuserban

That's what does all the fancy map stuff :)

On Wed, May 27, 2015 at 12:18 PM, Serban Teodorescu < [email protected]> wrote:

Why use leaflet in the first place?

Mie, 27 mai 2015, 18:59, mbellotti [email protected] a scris:

Okay, so this is not a bad link in an anchor tag. This is Leaflet.js incorrectly guessing the root path. I've been able to track this down within the library but I'm still trying to figure out how to fix it with creating a custom build of leaflet :/

— Reply to this email directly or view it on GitHub <https://github.com/OCHA-DAP/hdx-ckan/issues/2473#issuecomment-105974927 .

— Reply to this email directly or view it on GitHub https://github.com/OCHA-DAP/hdx-ckan/issues/2473#issuecomment-105982718.

mbellotti avatar May 27 '15 17:05 mbellotti

We have leaflet, mapbox and openstreetmap. Yey! We need to add google maps and yahoo maps :)

Mie, 27 mai 2015, 20:28, mbellotti [email protected] a scris:

That's what does all the fancy map stuff :)

On Wed, May 27, 2015 at 12:18 PM, Serban Teodorescu < [email protected]> wrote:

Why use leaflet in the first place?

Mie, 27 mai 2015, 18:59, mbellotti [email protected] a scris:

Okay, so this is not a bad link in an anchor tag. This is Leaflet.js incorrectly guessing the root path. I've been able to track this down within the library but I'm still trying to figure out how to fix it with creating a custom build of leaflet :/

— Reply to this email directly or view it on GitHub < https://github.com/OCHA-DAP/hdx-ckan/issues/2473#issuecomment-105974927 .

— Reply to this email directly or view it on GitHub <https://github.com/OCHA-DAP/hdx-ckan/issues/2473#issuecomment-105982718 .

— Reply to this email directly or view it on GitHub https://github.com/OCHA-DAP/hdx-ckan/issues/2473#issuecomment-106004958.

teodorescuserban avatar May 28 '15 04:05 teodorescuserban

Dan asked me to summarize the status of this issue:

The resources that are causing SSL to fail on some browsers are not loaded by HDX, they are loaded dynamically by leaflet.js which guesses the right url to use. In some cases it guesses incorrectly, using HTTP instead of HTTPS, triggering this error.

We could probably fix this, but we'd have to maintain a custom build of leaflet.js to do it. Before we consider that, Serban has raised a good point: we're using a lot of different map services that have overlapping features. Perhaps it's better to discuss streamlining that.

mbellotti avatar Jun 18 '15 13:06 mbellotti

+1

În Joi, 18 iun. 2015 la 16:47, mbellotti [email protected] a scris:

Dan asked me to summarize the status of this issue:

The resources that are causing SSL to fail on some browsers are not loaded by HDX, they are loaded dynamically by leaflet.js which guesses the right url to use. In some cases it guesses incorrectly, using HTTP instead of HTTPS, triggering this error.

We could probably fix this, but we'd have to maintain a custom build of leaflet.js to do it. Before we consider that, Serban has raised a good point: we're using a lot of different map services that have overlapping features. Perhaps it's better to discuss streamlining that.

— Reply to this email directly or view it on GitHub https://github.com/OCHA-DAP/hdx-ckan/issues/2473#issuecomment-113162200.

teodorescuserban avatar Jun 18 '15 16:06 teodorescuserban

Please be aware that we are already using leaflet/mapbox on org pages.

https://data.hdx.rwlabs.org/organization/wfp

teodorescuserban avatar Jun 19 '15 09:06 teodorescuserban